👌 IMPROVE: [code load] Enable utf-8 as the standard encoding for reading code from files#332
👌 IMPROVE: [code load] Enable utf-8 as the standard encoding for reading code from files#332
Conversation
…to unify across win, linux, os x
Codecov Report
@@ Coverage Diff @@
## master #332 +/- ##
=======================================
Coverage 87.43% 87.43%
=======================================
Files 12 12
Lines 1337 1337
=======================================
Hits 1169 1169
Misses 168 168
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
* enable execution checks for windows, linux, os x * test on PR first * add interpolation install from conda-forge * [temp] disable windows testing until executablebooks/MyST-NB#332 * turn of activate on push and set to schedule based testing
mmcky
changed the title
|
This looks reasonable to me, but the code has been refactored enough in the past few years that it needs some fixing up. Would you @mmcky be interested of resurrecting it? Unfortunately I don't see the old CI status any more to figure out the reason why it got the "on hold" label and draft status, if it's too much work to fix up this PR I would recommend to close it and open an issue for tracking the problem. |
2 participants
It looks like
windowsplatform doesn't by default always useutf-8when reading text from files. I think this is a sensible cross-platform default.QuantEcon/lecture-python.myst#144
There is also a related issue reported on stackoverflow