fix(core): keep resource date round trips timezone-stable (#2431) - #2435
Merged
Seiger merged 1 commit intoAug 27, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repro
With PHP
date.timezone=Asia/Tokyo, a resource date entered as2026/09/01 10:00:00is displayed again as2026/09/01 01:00:00after save/reopen. Saving again compounds the offset.Root Cause
toDateFormat()formats stored timestamps in UTC throughCarbon::createFromTimestamp($timestamp, 'UTC'), whiletoTimeStamp()parsed manager date fields throughmktime(), which uses PHP's runtime timezone. Non-UTC environments therefore shifted the timestamp on every manager round trip.Change Summary
gmmktime()sotoTimeStamp()uses the same UTC basis astoDateFormat().Asia/Tokyoopen/save/open round trip.Validation
git diff --checkwsl php -l core/src/Core.phpwsl php -l core/tests/Unit/CoreTest.phpAsia/Tokyo2026/09/01 10:00:00round-trips throughtoTimeStamp()andtoDateFormat()without changing on the second conversion.vendor/bin/pestis not available in the current localcore/vendor, so the full Pest suite was not run locally.Risk
Low. The fix is scoped to the shared date parser and aligns it with the existing UTC display path. It affects manager date strings that already round-trip through
toDateFormat()/toTimeStamp().