ENG-3578: Assessment Status dashboard card#8134
Open
kruulik wants to merge 23 commits into
Open
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Prevents the overflow scrollbar from covering the right-side row content (e.g. "N risk" labels) in the Assessment Status card columns. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
Adds alphaDashboardAssessmentStatusCard and uses it to gate the card's column (and the surrounding row when paired with the activity feed), matching the pattern previously used for the removed Astralis card flag. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
- Replace the custom CSS segment bar with the existing StackedBarChart from fidesui (same component DSRStatusCard uses) - Make segmentForAssessment exhaustive over AssessmentStatus so future enum values fail type-check instead of silently landing in "open" - Drop the getOrInsert Map helper; inline the get-or-create pattern - Trim isStale to a single guard clause; lean on date-fns subDays for the staleness threshold - Restore a brief TODO noting that this client-side aggregation should move to a /privacy-assessments/summary endpoint Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Drops the unit tests for the dashboard card's computeMetrics helper and unexports the helpers that were only exposed for testing. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
The assessments page doesn't yet support status / risk_level query filters, so each segment legend link just dropped the user on the unfiltered list. Point every link to the route root until the page gains real filtering. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket ENG-3578
Description Of Changes
Adds an Assessment Status card to the home dashboard. This intentionally replaces the Astralis status card, which was far from being complete, and required a lot of backend changes still.
Code Changes
clients/admin-ui/src/home/AssessmentStatusCard.tsx— new card component; pure-functioncomputeMetricsexported for unit tests; honest 4-bucket partition (each assessment counted once);isStaleskipsGENERATINGand treats missing timestamps as not-stale.clients/admin-ui/src/home/AstralisPanel.tsx,AstralisPanel.module.scss— deleted; the component was orphaned and the corresponding feature flag was removed.clients/admin-ui/src/flags.json— removed the unusedalphaDashboardAstralisCardflag entry, replace withalphaDashboardAssessmentStatusCardSteps to Confirm
cd clients/admin-ui && npm run dev:mockKnown limitations (called out in the file comments):
risk_levelfilter is applied client-side post-fetch; once the backend list endpoint supports it, move the filter server-side./privacy-assessments/summaryendpoint.Pre-Merge Checklist