cp: Fixed seg_paged_rw to use correct config parameter for page size#19687
Closed
sudeepdino008 wants to merge 4 commits intomainfrom
Closed
cp: Fixed seg_paged_rw to use correct config parameter for page size#19687sudeepdino008 wants to merge 4 commits intomainfrom
sudeepdino008 wants to merge 4 commits intomainfrom
Conversation
) Two domains can be affected by this bug -- rcache + commitment. How to fix/regen rcache domain: ``` ./build/bin/integration stage_custom_trace --domain=rcache --reset --chain chiado --datadir /erigon-data/chiado ./build/bin/erigon seg rm-state --datadir /erigon-data/chiado --domain=rcache —step 32-40 ./build/bin/integration stage_custom_trace --domain=rcache --chain chiado --datadir /erigon-data/chiado ```
sudeepdino008
force-pushed
the
cp_seg_paged_rw
branch
from
9b3770e to
977251d
Compare
1. dataWriter: use f.GetValuesOnCompressedPage() instead of h.HistoryValuesOnCompressedPage - Ensures writer uses same page size as compressor config (written to file header) - Reader uses decompressor.CompressedPageValuesCount() which reads from file header - This fixes mismatch where writer used 0 (no paging) but reader expected 64 (paging) 2. All NewPagedReader/GetFromPage: change compression flag from true to false - Production config uses Compression: seg.CompressNone with ValuesOnCompressedPage: 64 - Pages are used for grouping values but NOT zstd-compressed - If compression is enabled in future, files would be regenerated anyway
sudeepdino008
force-pushed
the
cp_seg_paged_rw
branch
from
977251d to
44cb7d4
Compare
Member
Author
|
seems like not needed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two domains can be affected by this bug -- rcache + commitment.
How to fix/regen rcache domain: