Identify more platforms and externalize environment checking#71
Closed
mmorel-35 wants to merge 26 commits intoengineerd:masterfrom
mmorel-35:patch-3
Closed
Identify more platforms and externalize environment checking#71mmorel-35 wants to merge 26 commits intoengineerd:masterfrom mmorel-35:patch-3
mmorel-35 wants to merge 26 commits intoengineerd:masterfrom
mmorel-35:patch-3
Conversation
Codecov Report
@@ Coverage Diff @@
## master #71 +/- ##
===========================================
- Coverage 62.81% 47.94% -14.88%
===========================================
Files 6 10 +4
Lines 199 340 +141
Branches 34 53 +19
===========================================
+ Hits 125 163 +38
- Misses 70 171 +101
- Partials 4 6 +2
Continue to review full report at Codecov.
|
Contributor
Author
|
Please @radu-matei , when do you think you'll find the time to review this ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @radu-matei , this PR includes the npm audit fix.
Please merge it first so the other PR won't fail.
The checking consist in :
Kubectl is now installed with the right version when kubernetes version can be identified throught the provided image or the kind config file
A metallb load-balancer can be installed with
loadBalancer : trueA local registry can be installed with
localRegistry : trueNB :
latestcan be a valid value for the kind version input parametercloses #9
closes #16
closes #81