Verso combat: Override less of throwing_enemy.gd#1870
Merged
Conversation
81f2dee to
47148a9
Compare
|
Play this branch at https://play.threadbare.game/branches/endlessm/wjt/verso-combat-override-less-of-throwing-enemy-gd. (This launches the game from the start, not directly at the change(s) in this pull request.) |
Previously throwing_enemy_health.gd overrode shoot_projectile() with two changes: 1. It adjusts the distance from the enemy that the projectile spawns; 2. It sets can_hit_enemy = true on the projectile. Since this scene was first written, it has become possible to adjust both of these properties. Make a copy of the projectile, verso_projectile.tscn, which sets can_hit_enemy to true. Adjust ThrowingEnemyHealth.tscn to use this copy of the projectile, and to set the distance to 75. Delete the shoot_projectile() override. Resolves #1316
47148a9 to
2216c49
Compare
Member
Author
|
I'm going to merge this because I am refactoring the projectile-spawning logic. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously throwing_enemy_health.gd overrode shoot_projectile() with two changes:
Since this scene was first written, it has become possible to adjust
both of these properties.
Make a copy of the projectile, verso_projectile.tscn, which sets
can_hit_enemy to true.
Adjust ThrowingEnemyHealth.tscn to use this copy of the projectile, and
to set the distance to 75.
Delete the shoot_projectile() override.
Resolves #1316