respecting ordered sequence while partial update is fixed by Natgho · Pull Request #9902 · encode/django-rest-framework

Natgho · 2026-02-25T07:08:43Z

Natgho · 2026-02-25T07:10:04Z

I considered including the ticket ID in the Description section of the test section, but decided it would be excessive. If you want it included, just let me know.

… keys is improved

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Natgho · 2026-03-02T11:56:04Z

The issues have been resolved and the PR looks ready. Is there anything else that needs improvement?

auvipy · 2026-03-02T15:12:46Z

lets wait for final rounds of reviews

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 3 out of 4 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Natgho · 2026-03-02T16:46:59Z

Finally!
Sometimes I wish I had been born in the years before AI was created...

Natgho · 2026-03-05T13:30:56Z

@auvipy what do you think?

Natgho · 2026-03-27T06:27:34Z

@auvipy I would appreciate your feedback.

browniebroke · 2026-03-27T08:27:33Z

rest_framework/fields.py

+            except (TypeError, KeyError, AttributeError):
+                # Fall back to treating the value as not provided.
+                val = []


Can you explain why we need this try/except? This line is not covered by the test so I'm curious...

The purpose of this is to ensure that the code flow continues so that the rendering process can be completed without interruption, even if the field cannot be converted in any way or if the getlist function throws an error. Since I don’t have an example of this, I don’t have a test for it either, but it’s not impossible—I’d rather be a bit overzealous than take a chance.

Ok, let's break this down:

The condition above checks html.is_html_input(dictionary) which checks that the dictionary has a getlist method, so I don't see how the AttributeError can happen

The QueryDict docs states that "It’s guaranteed to return a list unless the default value provided isn’t a list."

I see. Yes, you're right, it's impossible to get an AttributeError here, so I removed that AttributeError.

What about the other 2 exception types? We've not needed them so far, what changed that makes it needed?

rest_framework/fields.py

browniebroke · 2026-03-27T08:33:35Z

Also... What's up with all these added comments on code which basically unchanged? They are quite distracting... Did you write them or was it the work of an LLM?

Natgho · 2026-03-27T08:58:20Z

Also... What's up with all these added comments on code which basically unchanged? They are quite distracting... Did you write them or was it the work of an LLM?

I created the PR using AI, and I’m manually pushing AI for comment lines so I can track every action it takes in detail. If they seem intrusive or unnecessary, I can remove the comment lines.

browniebroke

Also... What's up with all these added comments on code which basically unchanged? They are quite distracting... Did you write them or was it the work of an LLM?

I created the PR using AI, and I’m manually pushing AI for comment lines so I can track every action it takes in detail. If they seem intrusive or unnecessary, I can remove the comment lines.

Ok that makes sense while you building it but I find the ratio of comments to code quite distracting, there are a

browniebroke · 2026-03-27T19:49:05Z

rest_framework/fields.py

+                # Call getlist with a single argument to support duck-typed MultiDicts
+                # that do not accept a default parameter.


That kind of explain why it was changed from dictionary.getlist(self.field_name, []) and exception handling was added, however this sems out of scope of what we're trying to achieve here. Let's keep the call how it was unless you can come up with a concrete example justifying this

browniebroke · 2026-03-27T19:51:19Z

rest_framework/fields.py

+            # For partial updates, avoid calling parse_html_list unless indexed keys are present.
+            # This reduces unnecessary parsing overhead for omitted list fields.


This one is good

browniebroke · 2026-03-27T19:51:25Z

rest_framework/fields.py

+            # For partial updates, avoid calling parse_html_list unless indexed keys are present.
+            # This reduces unnecessary parsing overhead for omitted list fields.
+            if getattr(self.root, 'partial', False):
+                # Quick check: are there any keys matching field_name[*]?


browniebroke · 2026-03-27T19:52:04Z

rest_framework/fields.py

+            # Parse indexed keys (e.g., field[0], field[1])
+            # This handles form submissions with explicit indices


Redundant with parse_html_list docstring

respecting ordered sequence while partial update is fixed

1544faf

Natgho mentioned this pull request Feb 25, 2026

ListField does not respect ordered sequence in form data with partial updates. #6202

Open

6 tasks

This comment was marked as outdated.

Sign in to view

Natgho and others added 4 commits March 2, 2026 12:20

Merge branch 'main' into 6202-partial-update-respect-ordered-sequence

4fdb19c

getting field order is re-ordered for backward compatibility

9caec6e

more detailed tests are added

88ea74c

.idea is added for Pycharm tmp files

0186c25

Natgho requested a review from ProstoSerghei March 2, 2026 09:39

auvipy requested review from auvipy and Copilot and removed request for ProstoSerghei March 2, 2026 10:07

Copilot started reviewing on behalf of auvipy March 2, 2026 10:07 View session

This comment was marked as outdated.

Sign in to view

Natgho added 2 commits March 2, 2026 13:31

reduntant check is removed, respecting o(n) search, checking prefixed…

069c9fb

… keys is improved

missing tests are added, more detailed

e1c8863

Natgho requested a review from Copilot March 2, 2026 10:32

Copilot started reviewing on behalf of Natgho March 2, 2026 10:33 View session

This comment was marked as outdated.

Sign in to view

Update tests/test_serializer_lists.py

1206cc4

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

auvipy requested a review from Copilot March 2, 2026 15:12

Copilot started reviewing on behalf of auvipy March 2, 2026 15:12 View session

This comment was marked as outdated.

Sign in to view

Natgho and others added 2 commits March 2, 2026 18:25

Update tests/test_fields.py

3bb0f16

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

comment is fixed for current solution explanation

12159c9

Natgho requested a review from Copilot March 2, 2026 15:29

Copilot started reviewing on behalf of Natgho March 2, 2026 15:30 View session

This comment was marked as outdated.

Sign in to view

Update tests/test_serializer_lists.py

1457bbc

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Natgho requested a review from Copilot March 2, 2026 15:37

Copilot started reviewing on behalf of Natgho March 2, 2026 15:37 View session

This comment was marked as outdated.

Sign in to view

standardized the errors

b0066ab

Natgho requested a review from Copilot March 2, 2026 16:00

Copilot started reviewing on behalf of Natgho March 2, 2026 16:01 View session

This comment was marked as outdated.

Sign in to view

Update rest_framework/fields.py

acf688b

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Natgho requested a review from Copilot March 2, 2026 16:06

Copilot started reviewing on behalf of Natgho March 2, 2026 16:07 View session

This comment was marked as outdated.

Sign in to view

listfield html input tests are seperated

733c207

Natgho requested a review from Copilot March 2, 2026 16:25

Copilot started reviewing on behalf of Natgho March 2, 2026 16:26 View session

Copilot AI reviewed Mar 2, 2026

View reviewed changes

Natgho and others added 2 commits March 4, 2026 15:45

Merge branch 'main' into 6202-partial-update-respect-ordered-sequence

471ce01

Merge branch 'main' into 6202-partial-update-respect-ordered-sequence

8afbbb2

Natgho added 2 commits March 10, 2026 17:35

Merge branch 'main' into 6202-partial-update-respect-ordered-sequence

5d20b80

Merge branch 'main' into 6202-partial-update-respect-ordered-sequence

b990481

browniebroke requested changes Mar 27, 2026

View reviewed changes

unnecessary AttributeError check part is removed

dd44e4d

browniebroke reviewed Mar 27, 2026

View reviewed changes

		# Call getlist with a single argument to support duck-typed MultiDicts
		# that do not accept a default parameter.

		# For partial updates, avoid calling parse_html_list unless indexed keys are present.
		# This reduces unnecessary parsing overhead for omitted list fields.

		# Parse indexed keys (e.g., field[0], field[1])
		# This handles form submissions with explicit indices

Uh oh!

Conversation

Natgho commented Feb 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Natgho commented Feb 25, 2026

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

Natgho commented Mar 2, 2026

Uh oh!

auvipy commented Mar 2, 2026

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Natgho commented Mar 2, 2026

Uh oh!

Natgho commented Mar 5, 2026

Uh oh!

Natgho commented Mar 27, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

browniebroke commented Mar 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Natgho commented Mar 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

browniebroke left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Natgho commented Feb 25, 2026 •

edited

Loading

browniebroke commented Mar 27, 2026 •

edited

Loading

Natgho commented Mar 27, 2026 •

edited

Loading