Skip to content

Update for ember-cli --typescript changes#137

Merged
simonihmig merged 1 commit intomainfrom
update-for-upstream-ts-changes
Jul 5, 2023
Merged

Update for ember-cli --typescript changes#137
simonihmig merged 1 commit intomainfrom
update-for-upstream-ts-changes

Conversation

@simonihmig
Copy link
Copy Markdown
Collaborator

Update our blueprint to take account of changes when generating the test-app with --typescript (PR). The new blueprint now drops ember-cli-typescript and opts into the TS transform of ember-cli-babel, which we must not override.

@simonihmig simonihmig added the bug Something isn't working label Jul 3, 2023
module.exports = function (defaults) {
let app = new EmberApp(defaults, {
autoImport: {
<% if (typescript) {%>'ember-cli-babel': { enableTypeScriptTransform: true },
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@simonihmig
Copy link
Copy Markdown
Collaborator Author

Successfully tested locally, CI failing due to #133

@simonihmig simonihmig requested a review from NullVoxPopuli July 3, 2023 20:16
@NullVoxPopuli
Copy link
Copy Markdown
Collaborator

Successfully tested locally, CI failing due to #133

🤞 #136

Update our blueprint to take account of changes when generating the test-app with `--typescript` ([PR](ember-cli/ember-cli#10283)). The new blueprint now drops ember-cli-typescript and opts into the TS transform of ember-cli-babel, which we must not override.
@simonihmig simonihmig force-pushed the update-for-upstream-ts-changes branch from 0d5e18d to 65dc56d Compare July 5, 2023 17:38
@simonihmig simonihmig merged commit 8089520 into main Jul 5, 2023
@simonihmig simonihmig deleted the update-for-upstream-ts-changes branch July 5, 2023 19:17
aklkv pushed a commit to aklkv/addon-blueprint that referenced this pull request Feb 8, 2026
…r-upstream-ts-changes

Update for ember-cli `--typescript` changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants