Skip to content

fix: handle partial Redis rejection writes #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thweetkomputer merged 1 commit into from
Aug 29, 2026
Merged

fix: handle partial Redis rejection writes #30

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 15 additions & 7 deletions src/brpc/acceptor.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,13 +250,21 @@ void Acceptor::RejectRedisConnection(int fd) {

static const char response[] =
"-ERR max number of clients reached\r\n";
ssize_t nwritten;
do {
nwritten = send(fd,
response,
sizeof(response) - 1,
MSG_DONTWAIT | MSG_NOSIGNAL);
} while (nwritten < 0 && errno == EINTR);
const size_t response_size = sizeof(response) - 1;
size_t offset = 0;
while (offset < response_size) {
const ssize_t nwritten = send(fd,
response + offset,
response_size - offset,
MSG_DONTWAIT | MSG_NOSIGNAL);
if (nwritten > 0) {
offset += nwritten;
} else if (nwritten < 0 && errno == EINTR) {
continue;
} else {
break;
}
}
}

void Acceptor::ListConnections(std::vector<SocketId>* conn_list,
Expand Down