Merged
Conversation
7be1aed Release 17-6.2.2 (#326) a09b7bc pg_query_deparse_comments_for_query: Add missing initialization (#324) 7eee7a6 pg_query_normalize: Fix handling of special strings in DefElem (#325) b2217bf Merge pull request #322 from pganalyze/release-17-6-2-1 300dc98 Apply suggestions from code review 443c1c1 Release 17-6.2.1 1915589 Add `pg_query_is_utility_stmt()` (#313) 693209e Run pgindent on pg_query_summary.c 5e3e4a7 Summary: Correctly handle schema qualfied filter columns d9867f6 Summary: Correctly handle "GRANT .. ON ALL TABLES IN SCHEMA" statemnets 426f56f Speed up summary truncate replacement logic (#319) 180ef56 Add missing top-level postgres_deparse.h in Makefile install step (#318) a192b38 Release 17-6.2.0 (#314) 6c04919 Update to Postgres 17.7 (#315) 3f1b676 Add test framework support for running individual tests. (#310) 03e2f43 Fix compilation warnings for the examples in README.md (#312) 64ace44 Add summary support for MERGE statements (#311) 581c9ac Add summary support for functions invoked via CALL (#309) bb1f456 Add truncation support to `pg_query_summary()` (#300) cd20bb8 Fix deparse of ALTER TABLE a ALTER b SET STATISTICS DEFAULT (#303) 32dfcf8 Add pg_query_parse_summary() and supporting code (#274) 9ac12d2 Deparser: Introduce pretty printing / formatting 1d80fc4 Fix bug in handle of MultiAssignRef nodes that follow a single column be38617 Add missing trailing space after LockingClause relation names 8d3336d Deparser: Rework handling of expressions inside typecasts ea8822a Use lowercase keywords in xmlroot functions 82b52b2 Deparser: Introduce dedicated state structure to replace StringInfo c863655 Bump Postgres to 17.5 and switch back to release tarballs dabe930 Add support for CALL statements 699f2b1 Update GitHub Actions Linux OS to 24.04 (#289) 8fbb9cc Allow alternate definitions of NAMEDATALEN identifier limit (#268) git-subtree-dir: c_src/libpg_query git-subtree-split: 7be1aed1f1f968a36cf541319f71e845850f0381
magnetised
force-pushed
the
magnetised/update-lib_pg_query
branch
from
5926278 to
7c9a610
Compare
magnetised
force-pushed
the
magnetised/update-lib_pg_query
branch
3 times, most recently
from
1f12627 to
0182a83
Compare
that could overflow the stack
magnetised
force-pushed
the
magnetised/update-lib_pg_query
branch
from
0182a83 to
83529c0
Compare
magnetised
force-pushed
the
magnetised/update-lib_pg_query
branch
from
6d3e629 to
a862a21
Compare
magnetised
force-pushed
the
magnetised/update-lib_pg_query
branch
from
a862a21 to
6a95fb5
Compare
alco
approved these changes
Mar 11, 2026
Member
alco
left a comment
alco
left a comment
There was a problem hiding this comment.
Does lib_pb_query in the title refer to https://github.com/pganalyze/libpg_query? Would it be prudent for us to include it as a submodule as opposed to maintaining a vendored source code tree? It's more difficult to keep track of which version it's on this way.
| fuzz-corpus: fuzz/_build/gen_deparse_corpus | ||
| @mkdir -p fuzz/corpus/deparse | ||
| fuzz/_build/gen_deparse_corpus fuzz/corpus/deparse \ | ||
| "SELECT 1" \ |
Member
There was a problem hiding this comment.
Is this autogenerated from fuzz/corpus/parse? Is there a script to regenerate the Makefile after we update the corpus?
Would be useful to have this meta documented for posterity.
Collaborator
Author
There was a problem hiding this comment.
it's just inline, not autogenerated.
Collaborator
Author
It's included as a git subtree not a submodule. so kind of tracked-vendored |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also adds a couple of validation steps:
And adds fuzzing to the library. This found a single problem, which was caused by NULLs in the AST passed to deparse.