Skip to content

Fix dropped commit fragments at batch size boundary #3728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
blj wants to merge 2 commits into from
Closed

Fix dropped commit fragments at batch size boundary #3728

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8f20b6f
Test batch ops replication bug at size boundary
blj Jan 16, 2026
3ad9803
Fix dropped commit fragments at batch size boundary
Jan 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion packages/sync-service/lib/electric/postgres/replication_client/message_converter.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,7 +227,12 @@ defmodule Electric.Postgres.ReplicationClient.MessageConverter do
txn_change_count: state.tx_change_count
}

last_log_offset = state.last_log_offset || LogOffset.new(Lsn.to_integer(fragment.lsn), 0)
last_log_offset =
if empty_commit_fragment_after_flush?(fragment, state, msg) do
LogOffset.new(Lsn.to_integer(msg.end_lsn), 0)
else
state.last_log_offset || LogOffset.new(Lsn.to_integer(fragment.lsn), 0)
end

{:ok,
%{
Expand Down Expand Up @@ -271,6 +276,10 @@ defmodule Electric.Postgres.ReplicationClient.MessageConverter do
LogOffset.new(state.txn_fragment.lsn, state.tx_op_index)
end

defp empty_commit_fragment_after_flush?(fragment, state, msg) do
fragment.change_count == 0 and not is_nil(state.last_log_offset) and not is_nil(msg.end_lsn)
end

defp change_received(%__MODULE__{} = state, bytes) do
%{
state
Expand Down
Loading
Loading