Skip to content

Multi sensitive volume clusters#1021

Merged
veprbl merged 25 commits intomainfrom
Multi-SensitiveVolume-Clusters
Apr 16, 2026
Merged

Multi sensitive volume clusters#1021
veprbl merged 25 commits intomainfrom
Multi-SensitiveVolume-Clusters

Conversation

@ybedfer
Copy link
Copy Markdown
Contributor

@ybedfer ybedfer commented Dec 19, 2025

Briefly, what does this PR introduce?

Implement realistic pitch into Multi-SensitiveVolume-MPGD, extending PR##1014.

What kind of change does this PR introduce?

Please check if this PR fulfills the following:

  • [ *] Changes have been communicated to collaborators

Does this PR introduce breaking changes? What changes might users need to make to their code?

No

Does this PR change default behavior?

Eventually yes.

yann bedfer and others added 10 commits November 13, 2025 18:27
…nstructors.

- "5SensVolumes" are designed for a 2D-strip readout, via "MPGDTrackerDigi".
- Modified constructors provide for both standard and "5SensVolumes".
- OuterBarrel constructor:
+ Simplified: providing now for only one <module> and one <layer> tag.
+ Sensisitive DetElement: in line with other constructors ("volSurfaceList",...).
…dicated configuration.

- Simplication: Standard XML (almost-)free of any reference to strips.
- Dedicated "craterlake_tracking_only_2DStrip" implementing "2DStrip" XMLs.
…PIXEL".

- 2 flavours of Barrel MPGDs implemented in 2 distinct XMLs: "_pixel"/"_2DStrip".
- "-DMPGD_INSTALL_PIXEL" allows to install "_pixel" instead of default "_2DStrip".
…xisting files in "install" directory.

- "_pixel" by default: so that the PR checks run successfully even when the new version of "MPGDTrackerDigi" (see "eic/EICrecon#2177") is not in place.
- Pre-existing files explicitly erased: since the cmake command "install" does not overwrite existing files.
@github-actions github-actions bot added topic: tracking topic: barrel Mid-rapidity detectors topic: forward Positive-rapidity detectors (hadron-going side) labels Dec 19, 2025
@ybedfer
Copy link
Copy Markdown
Contributor Author

ybedfer commented Dec 19, 2025

This is the last one of a sequence of 4 PRs:

  1. PR#2177 in EICrecon ("MPGDTrackerDigi: Multi-SensitiveVolume solution for the 2D-strip read… EICrecon#2177"): digitization with Multi-SensitiveVolume via MPGDTrackerDigi (and XY -> UV rotation in TrackerMeasurementFromHits).
  2. PR#Multi sensitive volume mpgd #1014 in epic: "_2DStrip" versions of XMLs, triggering MPGDTrackerDigi thanks to a <detector_name>__2DStrip constant (this, if loaded, which is not the default).
  3. PR#2264 in EICrecon ("Multi sensitive mpgd clusters EICrecon#2264"): clusterization in MPGDTrackerDigi + clustering in MPGDHitReconstruction
  4. PR#Multi sensitive volume clusters #1021 in epic: realistic pitch (and nStrips constants) going hand in hand with clusterization parameters in MPGDTrackerDigiConfig.

None of the above changes the default behavior (except for a slight modification of the cov. matrix in the current UV-segmentation implementation of the OuterBarrel). Would remain to have a last epic PR loading the "_2DStrip" XMLs, and hence installing the Multi-SensitiveVolume approach, by default.

@wdconinc wdconinc removed their request for review January 19, 2026 16:29
ybedfer and others added 2 commits February 2, 2026 00:08
…m XML.

- 2DStrip:
+ CyMBaL: v2.1 is the 5-SUBVOLUME version, v2.2 is clusterisation compatible.
+ Outer: same thing w/ v1.1 and v1.2.
- StripID: Merge in #767a3c7a0 of branch Multi-SensitiveVolume-MPGD.
@veprbl
Copy link
Copy Markdown
Member

veprbl commented Mar 26, 2026

Could you, please, resolve conflicts for this via rebase or merge?

Comment thread compact/tracking/mpgd_outerbarrel_2DStrip.xml Outdated
veprbl
veprbl previously approved these changes Apr 7, 2026
Copy link
Copy Markdown
Member

@veprbl veprbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

…e pixel-like segmentation.

The actual segmentation of the Radiator subVolumes is unimportant (being disregarded at
digitization time). But a pixel-like segmentation gives to the simulated data a better outlook.
And now the setting is consistent and consistent w/ that of CyMBaL.
veprbl
veprbl previously approved these changes Apr 7, 2026
Copy link
Copy Markdown
Member

@veprbl veprbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@veprbl veprbl merged commit 382a673 into main Apr 16, 2026
160 of 162 checks passed
@veprbl veprbl deleted the Multi-SensitiveVolume-Clusters branch April 16, 2026 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

topic: barrel Mid-rapidity detectors topic: forward Positive-rapidity detectors (hadron-going side) topic: tracking

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants