Run C++ code formatter in 3 folders by LorantLipcsei-ETAS · Pull Request #264 · eclipse-score/lifecycle

LorantLipcsei-ETAS · 2026-06-25T01:52:39Z

Run C++ code formatter in 3 folders :

examples
score/health_monitor
tests

- examples - score/health_monitor - tests

github-actions · 2026-06-25T01:53:28Z

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run --lockfile_mode=error //:license-check

Status: ⚠️ Needs Review

Click to expand output

[License Check Output]
Extracting Bazel installation...
Starting local Bazel server (8.4.2) and connecting to it...
INFO: Invocation ID: a504881a-2db7-4ff5-ad1c-e7c94c1f90c8
Computing main repo mapping: 
Computing main repo mapping: 
Loading: 
Loading: 0 packages loaded
Loading: 0 packages loaded
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Analyzing: target //:license-check (1 packages loaded, 0 targets configured)
Analyzing: target //:license-check (1 packages loaded, 0 targets configured)

Analyzing: target //:license-check (30 packages loaded, 10 targets configured)

Analyzing: target //:license-check (85 packages loaded, 10 targets configured)

Analyzing: target //:license-check (125 packages loaded, 327 targets configured)

Analyzing: target //:license-check (146 packages loaded, 5411 targets configured)

Analyzing: target //:license-check (146 packages loaded, 8031 targets configured)

Analyzing: target //:license-check (151 packages loaded, 8083 targets configured)

Analyzing: target //:license-check (158 packages loaded, 8130 targets configured)

Analyzing: target //:license-check (158 packages loaded, 8130 targets configured)

Analyzing: target //:license-check (158 packages loaded, 8130 targets configured)

Analyzing: target //:license-check (160 packages loaded, 8134 targets configured)

Analyzing: target //:license-check (161 packages loaded, 10018 targets configured)

Analyzing: target //:license-check (162 packages loaded, 10142 targets configured)

INFO: Analyzed target //:license-check (163 packages loaded, 10268 targets configured).
[12 / 16] JavaToolchainCompileClasses external/rules_java+/toolchains/platformclasspath_classes; 0s disk-cache, processwrapper-sandbox ... (2 actions running)
[14 / 16] JavaToolchainCompileBootClasspath external/rules_java+/toolchains/platformclasspath.jar; 0s disk-cache, processwrapper-sandbox
INFO: Found 1 target...
Target //:license.check.license_check up-to-date:
  bazel-bin/license.check.license_check
  bazel-bin/license.check.license_check.jar
INFO: Elapsed time: 26.342s, Critical Path: 2.87s
INFO: 16 processes: 12 internal, 3 processwrapper-sandbox, 1 worker.
INFO: Build completed successfully, 16 total actions
INFO: Running command line: bazel-bin/license.check.license_check ./formatted.txt <args omitted>
usage: org.eclipse.dash.licenses.cli.Main [-batch <int>] [-cd <url>]
       [-confidence <int>] [-ef <url>] [-excludeSources <sources>] [-help] [-lic
       <url>] [-project <shortname>] [-repo <url>] [-review] [-summary <file>]
       [-timeout <seconds>] [-token <token>]

github-actions · 2026-06-25T02:02:34Z

The created documentation from the pull request is available at: docu-html

NicolasFussberger · 2026-06-25T06:05:32Z

    Priority: 1
 IndentWidth: 4
-InsertNewlineAtEOF: true
+# InsertNewlineAtEOF: true


Why was this commented out?

I changed it because that line gave an unknown attribute error and searching for it revealed that this was encountered by others as well due to usually outdated clang-format ( under version 12, but ours is above 14 ).

Shall not be done. Thats not our problem - one need to use correct clang format.

Devcontainer uses clang-format version 20.1.8 and the .clang-format file works for this version. So I also think this change has to be reverted.

I will fix this and revert the change in the .clang-format file.

I reverted the change in the .clang-format file and re-ran the formatting using clang-format 20.1.8.

pawelrutkaq

Shall we integrate eclipse-score/tooling#294. since if we have formatting errors now, does CI job detect formatting issues ? If not, we shall fix CI too with this PR.

NicolasFussberger · 2026-06-26T09:05:43Z

Shall we integrate eclipse-score/tooling#294. since if we have formatting errors now, does CI job detect formatting issues ? If not, we shall fix CI too with this PR.

I think this would be good to use. Otherwise formatting will diverge again and again if this is not being enforced.

Fixed .clang-format file Re-run the formatting with clang-format 20.1.8

NicolasFussberger · 2026-06-30T05:46:28Z

Shall we integrate eclipse-score/tooling#294. since if we have formatting errors now, does CI job detect formatting issues ? If not, we shall fix CI too with this PR.

I think this would be good to use. Otherwise formatting will diverge again and again if this is not being enforced.

@LorantLipcsei-ETAS can you create a separate ticket for this?

LorantLipcsei-ETAS · 2026-06-30T08:55:35Z

Shall we integrate eclipse-score/tooling#294. since if we have formatting errors now, does CI job detect formatting issues ? If not, we shall fix CI too with this PR.

I think this would be good to use. Otherwise formatting will diverge again and again if this is not being enforced.

@LorantLipcsei-ETAS can you create a separate ticket for this?

Sure, here is the link to the ticket : #268.

LorantLipcsei-ETAS · 2026-06-30T09:10:11Z

@paulquiring took over the WI ( https://dev.azure.com/bosch-denso-common/VRTE-Adaptive/_workitems/edit/98344 ) so he will finish this PR.

paulquiring · 2026-07-17T08:27:18Z

Closed, required tooling is introduced in #313. After that the code base will be formatted in one go.

AZB 98344 Run C++ code formatter in 3 folders

a33d34a

- examples - score/health_monitor - tests

github-project-automation Bot added this to LCM - Lifecycle & Health FT Jun 25, 2026

github-project-automation Bot moved this to Backlog in LCM - Lifecycle & Health FT Jun 25, 2026

LorantLipcsei-ETAS requested a deployment to workflow-approval June 25, 2026 01:52 — with GitHub Actions Waiting

NicolasFussberger reviewed Jun 25, 2026

View reviewed changes

pawelrutkaq requested changes Jun 26, 2026

View reviewed changes

Fixes related to clang-format (eclipse-score#264)

b50beca

Fixed .clang-format file Re-run the formatting with clang-format 20.1.8

LorantLipcsei-ETAS requested a deployment to workflow-approval June 26, 2026 12:54 — with GitHub Actions Waiting

anmittag assigned anmittag and LorantLipcsei-ETAS and unassigned anmittag Jul 16, 2026

paulquiring closed this Jul 17, 2026

github-project-automation Bot moved this from Backlog to Done in LCM - Lifecycle & Health FT Jul 17, 2026

Uh oh!

Conversation

LorantLipcsei-ETAS commented Jun 25, 2026

Uh oh!

github-actions Bot commented Jun 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

License Check Results

Uh oh!

github-actions Bot commented Jun 25, 2026

Uh oh!

NicolasFussberger Jun 25, 2026

Choose a reason for hiding this comment

Uh oh!

LorantLipcsei-ETAS Jun 25, 2026

Choose a reason for hiding this comment

Uh oh!

pawelrutkaq Jun 26, 2026

Choose a reason for hiding this comment

Uh oh!

NicolasFussberger Jun 26, 2026

Choose a reason for hiding this comment

Uh oh!

LorantLipcsei-ETAS Jun 26, 2026

Choose a reason for hiding this comment

Uh oh!

LorantLipcsei-ETAS Jun 26, 2026

Choose a reason for hiding this comment

Uh oh!

pawelrutkaq left a comment

Choose a reason for hiding this comment

Uh oh!

NicolasFussberger commented Jun 26, 2026

Uh oh!

NicolasFussberger commented Jun 30, 2026

Uh oh!

LorantLipcsei-ETAS commented Jun 30, 2026

Uh oh!

LorantLipcsei-ETAS commented Jun 30, 2026

Uh oh!

paulquiring commented Jul 17, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

github-actions Bot commented Jun 25, 2026 •

edited

Loading