Skip to content

Activate content assist only when caret enters the viewer #2305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iloveeclipse merged 1 commit into from
Mar 4, 2026
+59 −14
Merged

Activate content assist only when caret enters the viewer #2305

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
73 changes: 59 additions & 14 deletions ....debug.ui/ui/org/eclipse/debug/internal/ui/views/variables/details/DefaultDetailPane.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*******************************************************************************
* Copyright (c) 2006, 2019 IBM Corporation and others.
* Copyright (c) 2006, 2026 IBM Corporation and others.
*
* This program and the accompanying materials
* are made available under the terms of the Eclipse Public License 2.0
Expand Down Expand Up @@ -423,6 +423,10 @@ private boolean containsLineDelimiter(String str) {
private IPropertyChangeListener fPreferenceStorePropertyChangeListener;
private WhitespaceCharacterPainter fWhiteSpacePainter;

private TextViewerAction contentAssistAction;

private ActionHandler contentAssistActionHandler;

@Override
public Control createControl(Composite parent) {

Expand Down Expand Up @@ -542,6 +546,8 @@ public void focusGained(FocusEvent e) {

updateAction(DETAIL_FIND_REPLACE_TEXT_ACTION);
fHasFocus = true;
activateContentAssistHandler(contentAssistAction, contentAssistActionHandler);

}

@Override
Expand All @@ -556,6 +562,7 @@ public void focusLost(FocusEvent e) {

getViewSite().getActionBars().updateActionBars();
fHasFocus = false;
deactivateContentAssistHandler();
}
});

Expand Down Expand Up @@ -591,18 +598,29 @@ public void focusLost(FocusEvent e) {
* Creates the actions to add to the context menu
*/
private void createActions() {
TextViewerAction textAction= new TextViewerAction(fSourceViewer, ISourceViewer.CONTENTASSIST_PROPOSALS);
textAction.setActionDefinitionId(ITextEditorActionDefinitionIds.CONTENT_ASSIST_PROPOSALS);
textAction.configureAction(DetailMessages.DefaultDetailPane_Co_ntent_Assist_3, IInternalDebugCoreConstants.EMPTY_STRING,IInternalDebugCoreConstants.EMPTY_STRING);
textAction.setImageDescriptor(DebugPluginImages.getImageDescriptor(IDebugUIConstants.IMG_ELCL_CONTENT_ASSIST));
textAction.setDisabledImageDescriptor(DebugPluginImages.getImageDescriptor(IDebugUIConstants.IMG_DLCL_CONTENT_ASSIST));
PlatformUI.getWorkbench().getHelpSystem().setHelp(textAction, IDebugHelpContextIds.DETAIL_PANE_CONTENT_ASSIST_ACTION);
ActionHandler actionHandler = new ActionHandler(textAction);
IHandlerService handlerService = getViewSite().getService(IHandlerService.class);
fContentAssistActivation = handlerService.activateHandler(textAction.getActionDefinitionId(), actionHandler);
setAction(DETAIL_CONTENT_ASSIST_ACTION, textAction);

textAction= new TextViewerAction(fSourceViewer, ITextOperationTarget.SELECT_ALL);
contentAssistAction = new TextViewerAction(fSourceViewer, ISourceViewer.CONTENTASSIST_PROPOSALS);

contentAssistAction.setActionDefinitionId(ITextEditorActionDefinitionIds.CONTENT_ASSIST_PROPOSALS);
contentAssistAction.configureAction(DetailMessages.DefaultDetailPane_Co_ntent_Assist_3,
IInternalDebugCoreConstants.EMPTY_STRING, IInternalDebugCoreConstants.EMPTY_STRING);
contentAssistAction
.setImageDescriptor(DebugPluginImages.getImageDescriptor(IDebugUIConstants.IMG_ELCL_CONTENT_ASSIST));
contentAssistAction.setDisabledImageDescriptor(
DebugPluginImages.getImageDescriptor(IDebugUIConstants.IMG_DLCL_CONTENT_ASSIST));
PlatformUI.getWorkbench().getHelpSystem().setHelp(contentAssistAction,
IDebugHelpContextIds.DETAIL_PANE_CONTENT_ASSIST_ACTION);
contentAssistActionHandler = new ActionHandler(contentAssistAction);
setAction(DETAIL_CONTENT_ASSIST_ACTION, contentAssistAction);

StyledText text = fSourceViewer.getTextWidget();

text.addCaretListener(event -> {
if (text.isFocusControl()) {
activateContentAssistHandler(contentAssistAction, contentAssistActionHandler);
}
});

TextViewerAction textAction = new TextViewerAction(fSourceViewer, ITextOperationTarget.SELECT_ALL);
textAction.configureAction(DetailMessages.DefaultDetailPane_Select__All_5, IInternalDebugCoreConstants.EMPTY_STRING,IInternalDebugCoreConstants.EMPTY_STRING);
textAction.setActionDefinitionId(IWorkbenchCommandConstants.EDIT_SELECT_ALL);
PlatformUI.getWorkbench().getHelpSystem().setHelp(textAction, IDebugHelpContextIds.DETAIL_PANE_SELECT_ALL_ACTION);
Expand Down Expand Up @@ -650,10 +668,37 @@ private void createActions() {
}

/**
* Create the context menu particular to the detail pane. Note that anyone
* Activates the content assist handler for the specified viewer action.
*
* @param contAssistTextViewer the viewer action providing the action definition
* ID
* @param actionHandler the handler to activate
*/
private void activateContentAssistHandler(TextViewerAction contAssistTextViewer, ActionHandler actionHandler) {
if (fContentAssistActivation == null) {
IHandlerService handlerService = getViewSite().getService(IHandlerService.class);
fContentAssistActivation = handlerService.activateHandler(contAssistTextViewer.getActionDefinitionId(),
actionHandler);
}
}

/**
* Deactivates the content assist handler.
*/
private void deactivateContentAssistHandler() {
if (fContentAssistActivation != null) {
IHandlerService handlerService = getViewSite().getService(IHandlerService.class);
handlerService.deactivateHandler(fContentAssistActivation);
fContentAssistActivation = null;
}
}

/**
* Create the context menu particular to the detail pane. Note that anyone
* wishing to contribute an action to this menu must use
* <code>IDebugUIConstants.VARIABLE_VIEW_DETAIL_ID</code> as the
* <code>targetID</code> in the extension XML.
*
* @param menuControl the control to create the context menu on
*/
protected void createDetailContextMenu(Control menuControl) {
Expand Down
Loading