Skip to content

feat(orch): add observability for build cache #2279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jakubno wants to merge 2 commits into
base: main
Choose a base branch
from
+22 −1
Open

feat(orch): add observability for build cache #2279

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fc07293
feat(orch): add observability for build cache
jakubno Apr 1, 2026
e889caf
chore: address pr comments
jakubno Apr 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 22 additions & 1 deletion packages/orchestrator/pkg/sandbox/build/cache.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,16 +8,26 @@ import (
"time"

"github.com/jellydator/ttlcache/v3"
"go.opentelemetry.io/otel"
"go.opentelemetry.io/otel/metric"
"go.uber.org/zap"
"golang.org/x/sys/unix"

"github.com/e2b-dev/infra/packages/orchestrator/pkg/cfg"
"github.com/e2b-dev/infra/packages/orchestrator/pkg/units"
"github.com/e2b-dev/infra/packages/shared/pkg/featureflags"
"github.com/e2b-dev/infra/packages/shared/pkg/logger"
"github.com/e2b-dev/infra/packages/shared/pkg/utils"
)

var fallbackDiffSize = units.MBToBytes(100)
var (
fallbackDiffSize = units.MBToBytes(100)

meter = otel.Meter("github.com/e2b-dev/infra/packages/orchestrator/pkg/sandbox/build")
residenceDurationMetric = utils.Must(meter.Int64Histogram("orchestrator.build.cache.residence_duration",
metric.WithDescription("How long a diff was kept in the local build cache before eviction"),
metric.WithUnit("s")))
)

type deleteDiff struct {
size int64
Expand All @@ -37,6 +47,8 @@ type DiffStore struct {
pdSizes map[DiffStoreKey]*deleteDiff
pdMu sync.RWMutex
pdDelay time.Duration

insertionTimes sync.Map // map[DiffStoreKey]time.Time — tracks when each diff was cached
}

func NewDiffStore(
Expand Down Expand Up @@ -65,7 +77,13 @@ func NewDiffStore(
}

cache.OnEviction(func(ctx context.Context, _ ttlcache.EvictionReason, item *ttlcache.Item[DiffStoreKey, Diff]) {
if insertedAt, ok := ds.insertionTimes.LoadAndDelete(item.Key()); ok {
duration := time.Since(insertedAt.(time.Time))
residenceDurationMetric.Record(ctx, int64(duration.Seconds()))
Comment thread
jakubno marked this conversation as resolved.
}

Comment thread
jakubno marked this conversation as resolved.
buildData := item.Value()

// buildData will be deleted by calling buildData.Close()
defer ds.resetDelete(item.Key())

Expand Down Expand Up @@ -110,6 +128,8 @@ func (s *DiffStore) Get(ctx context.Context, diff Diff) (Diff, error) {
}

if !found {
s.insertionTimes.Store(diff.CacheKey(), time.Now())

err := diff.Init(ctx)
if err != nil {
return nil, fmt.Errorf("failed to init source: %w", err)
Expand All @@ -122,6 +142,7 @@ func (s *DiffStore) Get(ctx context.Context, diff Diff) (Diff, error) {
func (s *DiffStore) Add(d Diff) {
s.resetDelete(d.CacheKey())
s.cache.Set(d.CacheKey(), d, ttlcache.DefaultTTL)
s.insertionTimes.LoadOrStore(d.CacheKey(), time.Now())
}

func (s *DiffStore) Has(d Diff) bool {
Expand Down
Loading