[#326] - Prevent focus on background element while Modal is open#349
Closed
noahhefner wants to merge 1 commit intodullage:developfrom
Closed
[#326] - Prevent focus on background element while Modal is open#349noahhefner wants to merge 1 commit intodullage:developfrom
noahhefner wants to merge 1 commit intodullage:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello and thank you for creating Flatnotes! I use it constantly in my homelab as my primary note taking system.
Opening this PR as a suggestion to address bug #326 where background elements can be focused while a modal is open. The implementation is pretty straightforward; a
data-inert-scopeattribute has been added to elements that should be non-focusable while a Modal is open. When a Modal is opened, a watch function will add theinertattribute to those elements, preventing them from being focused. When a Modal is closed, theinertattribute is removed.