Skip to content

refactor(Empty): fix typo error#7670

Merged
ArgoZhang merged 1 commit intomainfrom
fix-empty
Feb 14, 2026
Merged

refactor(Empty): fix typo error#7670
ArgoZhang merged 1 commit intomainfrom
fix-empty

Conversation

@ArgoZhang
Copy link
Member

@ArgoZhang ArgoZhang commented Feb 14, 2026

Link issues

fixes #7669

Summary By Copilot

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Correct the Empty component template CSS class name and align related styles and tests.

Bug Fixes:

  • Fix misspelled Empty component template CSS class from empty-telemplate to empty-template to ensure consistent styling and markup.

Tests:

  • Update unit test expectation to match the corrected Empty component template CSS class name.

Copilot AI review requested due to automatic review settings February 14, 2026 02:37
@bb-auto bb-auto bot added the documentation Improvements or additions to documentation label Feb 14, 2026
@bb-auto bb-auto bot added this to the v10.3.0 milestone Feb 14, 2026
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Feb 14, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Renames the mis-typed empty-telemplate CSS class and its usages to empty-template, and cleans up stray BOM characters in the Razor and SCSS files.

File-Level Changes

Change Details Files
Corrected the Empty component template wrapper CSS class name and updated all usages.
  • Renamed the wrapper div class from empty-telemplate to empty-template in the Empty component Razor markup.
  • Renamed the corresponding SCSS selector from .empty-telemplate to .empty-template to keep styles aligned.
  • Updated the SelectTable EmptyTemplate unit test expectation string to match the new empty-template class name.
src/BootstrapBlazor/Components/Empty/Empty.razor
src/BootstrapBlazor/Components/Empty/Empty.razor.scss
test/UnitTest/Components/SelectTableTest.cs
Removed unintended BOM characters at the start of source files.
  • Removed leading BOM character from Empty.razor.
  • Removed leading BOM character from Empty.razor.scss.
src/BootstrapBlazor/Components/Empty/Empty.razor
src/BootstrapBlazor/Components/Empty/Empty.razor.scss

Assessment against linked issues

Issue Objective Addressed Explanation
#7669 Fix the typo in the Empty component where the CSS class/template name is misspelled (e.g., empty-telemplateempty-template) across component markup, styles, and related tests.
#7669 Add sample code/documentation demonstrating how to use the Empty component. The PR only updates the typo in the component markup, SCSS, and a unit test. It does not add any sample code or documentation for the Empty component.

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • Renaming the empty-telemplate CSS class to empty-template could be a breaking change for consumers who target the old class in custom styles or tests; consider adding a temporary compatibility alias or documenting the change where you track breaking CSS changes.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Renaming the `empty-telemplate` CSS class to `empty-template` could be a breaking change for consumers who target the old class in custom styles or tests; consider adding a temporary compatibility alias or documenting the change where you track breaking CSS changes.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@ArgoZhang ArgoZhang merged commit def30fc into main Feb 14, 2026
8 checks passed
@ArgoZhang ArgoZhang deleted the fix-empty branch February 14, 2026 02:39
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request fixes a typo in the Empty component where the CSS class name was incorrectly spelled as empty-telemplate instead of empty-template. This inconsistency affected the component's markup, styles, and test assertions.

Changes:

  • Corrected CSS class name from empty-telemplate to empty-template in Empty component markup, styles, and tests
  • Removed leading BOM character () from Empty.razor and Empty.razor.scss files

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
src/BootstrapBlazor/Components/Empty/Empty.razor Fixed CSS class name typo and removed BOM character
src/BootstrapBlazor/Components/Empty/Empty.razor.scss Fixed CSS selector typo and removed BOM character
test/UnitTest/Components/SelectTableTest.cs Updated test assertion to match corrected CSS class name

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link

codecov bot commented Feb 14, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (7b33538) to head (e6bd115).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #7670   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          749       749           
  Lines        33196     33196           
  Branches      4605      4605           
=========================================
  Hits         33196     33196           
Flag Coverage Δ
BB 100.00% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

refactor(Empty): fix typo error

1 participant