Open
Conversation
cb19291 to
b56acb8
Compare
JoeRobich
commented
Feb 14, 2026
JoeRobich
commented
Feb 14, 2026
tasks/runTask.ts
Outdated
| * Licensed under the MIT License. See License.txt in the project root for license information. | ||
| *--------------------------------------------------------------------------------------------*/ | ||
|
|
||
| export function runTask(task: () => Promise<void>): void { |
Member
Author
There was a problem hiding this comment.
Since CJS doesn't support top-level await we need a little wrapper function so our async tasks can run.
7f64015 to
bb44da1
Compare
dibarbet
reviewed
Feb 18, 2026
63eb76b to
f6ef6a3
Compare
1be624a to
d3741ff
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves us from Gulp to running node scripts via
node run. It exposes all our tasks as entries in the packages.json scripts section. This allows us to usenpm run {task}in the same manner as we were usingnpx gulp {task}.Problems with gulp
Aside
I investigated using node's built-in type stripping support to replace our use of ts-node, but it required changes inside the /src directory which I was trying to avoid. At some point I am sure we can move all our code to be compatible in order to avoid the compilation step. In particular the changes required meant
<type>casts becameas type, enum types became const lookups, and imports of Typescripttypedefinitions were changed toimport type.