Repository navigation
Avoid checked-build assertion for open Nullable assignability - #135208
Merged
Merged
Conversation
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Co-authored-by: jkotas <6668460+jkotas@users.noreply.github.com>
Co-authored-by: jkotas <6668460+jkotas@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix assert failure in CastHelpers.IsNullableForType
Avoid checked-build assertion for open Nullable<> assignability
Oct 5, 2026
Contributor
|
Tagging subscribers to this area: @steveisok, @dotnet/area-system-reflection |
jkotas
reviewed
Oct 5, 2026
jkotas
reviewed
Oct 5, 2026
jkotas
reviewed
Oct 5, 2026
Co-authored-by: jkotas <6668460+jkotas@users.noreply.github.com>
Co-authored-by: jkotas <6668460+jkotas@users.noreply.github.com>
jkotas
changed the title
jkotas
marked this pull request as ready for review
October 5, 2026 14:52
This was referenced Oct 5, 2026
Open
steveisok
approved these changes
Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Open
Nullable<>has a type descriptor as its generic argument, but nullable casting treated that argument as aMethodTable*. Consequently, a legalIsAssignableFromcall asserts on checked builds.TypeHandleand read them through a managedMethodTable.NullableTypeproperty. KeepInstantiationArg0only for debug verification when the argument is a method table.Nullable<>assignability cases alongside the existing nullable cases.