Reset frameNeedsTailcallUpdate when we don't call interp code#126475
Open
BrzVlad wants to merge 1 commit intodotnet:mainfrom
Open
Reset frameNeedsTailcallUpdate when we don't call interp code#126475BrzVlad wants to merge 1 commit intodotnet:mainfrom
BrzVlad wants to merge 1 commit intodotnet:mainfrom
Conversation
We expect that frameNeedsTailcallUpdate has a false default value. When we encounter a call flagged as tail, we set this variable to true and then proceed with the rest of the call. Once we setup the frame for the tailcall we reset this variable. The problem is that some code paths for the call could end up invoking compiled code. In this case we failed to clear the tailcall flag which means that, after returning from compiled code, if we would encounter a calling opcode that doesn't reset frameNeedsTailcallUpdate (for example INTOP_NEWOBJ), we would incorrectly proceed with a tailcall. Fixes Runtime_72845 in DOTNET_InterpMode=1
Member
Author
|
FYI @kotlarmilos |
Contributor
|
Tagging subscribers to this area: @BrzVlad, @janvorli, @kg |
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes an interpreter tailcall state bug where frameNeedsTailcallUpdate could remain set after invoking compiled/unmanaged code, causing subsequent non-tail opcodes (e.g., INTOP_NEWOBJ) to incorrectly perform tailcall frame updates.
Changes:
- Clear
frameNeedsTailcallUpdatebefore invoking unmanagedcallipaths (P/Invoke). - Clear
frameNeedsTailcallUpdatebefore invoking compiled managedcalliviaInvokeCalliStub. - Clear
frameNeedsTailcallUpdatebefore invoking compiled delegate calls and compiled managed method fallback paths.
This was referenced Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We expect that frameNeedsTailcallUpdate has a false default value. When we encounter a call flagged as tail, we set this variable to true and then proceed with the rest of the call. Once we setup the frame for the tailcall we reset this variable. The problem is that some code paths for the call could end up invoking compiled code. In this case we failed to clear the tailcall flag which means that, after returning from compiled code, if we would encounter a calling opcode that doesn't reset frameNeedsTailcallUpdate (for example INTOP_NEWOBJ), we would incorrectly proceed with a tailcall.
Fixes Runtime_72845 in DOTNET_InterpMode=1
Regressed after #123225