Skip to content

Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2942751#126452

Open
dotnet-bot wants to merge 2 commits intomainfrom
locfiles/795cf3c7-ec82-436f-9e5f-f6c977ae40dc
Open

Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2942751#126452
dotnet-bot wants to merge 2 commits intomainfrom
locfiles/795cf3c7-ec82-436f-9e5f-f6c977ae40dc

Conversation

@dotnet-bot
Copy link
Copy Markdown
Collaborator

This is the pull request automatically created by the OneLocBuild task in the build process to check-in localized files generated based upon translation source files (.lcl files) handed-back from the downstream localization pipeline. If there are issues in translations, visit https://aka.ms/icxLocBug and log bugs for fixes. The OneLocBuild wiki is https://aka.ms/onelocbuild and the localization process in general is documented at https://aka.ms/AllAboutLoc.

@dotnet-policy-service
Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @dotnet/area-system-text-json
See info in area-owners.md if you want to be subscribed.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 2, 2026

🤖 Copilot Code Review — PR #126452

Note

This review was generated by GitHub Copilot.

Holistic Assessment

Motivation: This is a standard automated localization check-in by the OneLocBuild pipeline. Two previously untranslated diagnostic strings for the System.Text.Json source generator (JsonIgnoreConditionAlwaysInvalidOnTypeFormat and JsonIgnoreConditionAlwaysInvalidOnTypeTitle) are now receiving their localized translations across all 13 supported languages.

Approach: The approach is the standard OneLocBuild process — state="new" entries with English fallback text are replaced with state="translated" entries containing the actual localized strings. This is the expected workflow for localization in dotnet/runtime.

Summary: ✅ LGTM. This is a routine, low-risk localization update. All 13 language files are consistently updated, the {0} format placeholder is preserved in all translations of the format string, and the title string (which has no placeholders) is correctly translated without introducing any. No code logic, public API, or behavioral changes are involved.


Detailed Findings

✅ Format Placeholder Preservation — Verified

The JsonIgnoreConditionAlwaysInvalidOnTypeFormat string contains a {0} placeholder for the type name. All 13 translated targets correctly preserve this placeholder. This is the most important correctness check for localization of format strings.

✅ Translation State Transition — Correct

All changes follow the expected pattern: state="new"state="translated", and the English fallback text is replaced with the localized content. The <source> elements are unchanged, which is correct — only the <target> elements are modified.

✅ Consistency Across Languages — Verified

All 13 language files (cs, de, es, fr, it, ja, ko, pl, pt-BR, ru, tr, zh-Hans, zh-Hant) receive identical structural changes for the same two trans-units. No language files are missing or have asymmetric changes.

✅ No Code or Behavioral Changes

This PR only modifies .xlf resource files. No source code, public API surface, tests, or runtime behavior are affected.

Generated by Code Review for issue #126452 ·

@dotnet-bot dotnet-bot changed the title Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2942011 Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2942029 Apr 2, 2026
@dotnet-bot dotnet-bot changed the title Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2942029 Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2942032 Apr 2, 2026
@dotnet-bot dotnet-bot changed the title Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2942032 Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2942120 Apr 2, 2026
@dotnet-bot dotnet-bot changed the title Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2942120 Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2942218 Apr 2, 2026
@dotnet-bot dotnet-bot changed the title Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2942218 Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2942233 Apr 2, 2026
@dotnet-bot dotnet-bot changed the title Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2942233 Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2942262 Apr 2, 2026
@dotnet-bot dotnet-bot changed the title Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2942262 Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2942302 Apr 2, 2026
@dotnet-bot dotnet-bot changed the title Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2942302 Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2942338 Apr 2, 2026
@dotnet-bot dotnet-bot changed the title Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2942338 Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2942351 Apr 2, 2026
@dotnet-bot dotnet-bot changed the title Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2942351 Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2942371 Apr 2, 2026
@dotnet-bot dotnet-bot changed the title Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2942371 Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2942394 Apr 2, 2026
@dotnet-bot dotnet-bot changed the title Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2942394 Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2942409 Apr 2, 2026
@dotnet-bot dotnet-bot changed the title Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2942409 Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2942427 Apr 2, 2026
@dotnet-bot dotnet-bot changed the title Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2942427 Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2942497 Apr 2, 2026
@dotnet-bot dotnet-bot changed the title Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2942497 Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2942540 Apr 2, 2026
@dotnet-bot dotnet-bot changed the title Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2942540 Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2942558 Apr 2, 2026
@dotnet-bot dotnet-bot changed the title Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2942558 Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2942576 Apr 2, 2026
@dotnet-bot dotnet-bot changed the title Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2942576 Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2942586 Apr 2, 2026
@dotnet-bot dotnet-bot changed the title Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2942586 Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2942602 Apr 2, 2026
@dotnet-bot dotnet-bot changed the title Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2942602 Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2942647 Apr 2, 2026
@dotnet-bot dotnet-bot changed the title Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2942647 Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2942665 Apr 3, 2026
@dotnet-bot dotnet-bot changed the title Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2942665 Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2942699 Apr 3, 2026
@dotnet-bot dotnet-bot changed the title Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2942699 Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2942722 Apr 3, 2026
@dotnet-bot dotnet-bot changed the title Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2942722 Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2942751 Apr 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant