Skip to content

Process.Linux/OSX: avoid loading full ProcessInfo for ProcessName and ToString. #126449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tmds wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Process.Linux/OSX: avoid loading full ProcessInfo for ProcessName and ToString. #126449

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0c065b2
Process.Linux/OSX: avoid loading full ProcessInfo for ProcessName and…
tmds Apr 1, 2026
acd9842
Use expression-body syntax.
tmds Apr 2, 2026
6e4bf2b
Merge branch 'main' into processname_linux
tmds Apr 3, 2026
ed184f1
Apply suggestions from code review
tmds Apr 3, 2026
6a6cba0
Remove IsProcessNameSupported.
tmds Apr 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions src/libraries/System.Diagnostics.Process/src/System/Diagnostics/Process.Unix.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -434,14 +434,5 @@ private SafeWaitHandle GetSafeWaitHandle()

private static bool WaitForInputIdleCore(int _ /*milliseconds*/) => throw new InvalidOperationException(SR.InputIdleUnknownError);

/// <summary>Gets the friendly name of the process.</summary>
public string ProcessName
{
get
{
EnsureState(State.HaveProcessInfo);
return _processInfo!.ProcessName;
}
}
}
}
36 changes: 0 additions & 36 deletions src/libraries/System.Diagnostics.Process/src/System/Diagnostics/Process.Windows.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,6 @@ namespace System.Diagnostics
{
public partial class Process : IDisposable
{
private string? _processName;

private bool _haveMainWindow;
private IntPtr _mainWindowHandle;
private string? _mainWindowTitle;
Expand Down Expand Up @@ -113,7 +111,6 @@ private void RefreshCore()
_haveMainWindow = false;
_mainWindowTitle = null;
_haveResponding = false;
_processName = null;
}

/// <summary>Additional logic invoked when the Process is closed.</summary>
Expand Down Expand Up @@ -534,39 +531,6 @@ private SafeProcessHandle GetProcessHandle(int access, bool throwIfExited = true

private static ConsoleEncoding GetStandardOutputEncoding() => GetEncoding((int)Interop.Kernel32.GetConsoleOutputCP());

/// <summary>Gets the friendly name of the process.</summary>
public string ProcessName
{
get
{
if (_processName == null)
{
// If we already have the name via a populated ProcessInfo
// then use that one.
if (_processInfo?.ProcessName != null)
{
_processName = _processInfo!.ProcessName;
}
else
{
// Ensure that the process is not yet exited
EnsureState(State.HaveNonExitedId);
_processName = ProcessManager.GetProcessName(_processId, _machineName);

// Fallback to slower ProcessInfo implementation if optimized way did not return a
// process name (e.g. in case of missing permissions for Non-Admin users)
if (_processName == null)
{
EnsureState(State.HaveProcessInfo);
_processName = _processInfo!.ProcessName;
}
}
}

return _processName;
}
}

private bool StartCore(ProcessStartInfo startInfo, SafeFileHandle? stdinHandle, SafeFileHandle? stdoutHandle, SafeFileHandle? stderrHandle)
{
SafeProcessHandle startedProcess = SafeProcessHandle.StartCore(startInfo, stdinHandle, stdoutHandle, stderrHandle);
Expand Down
Loading
Loading