Re-enable the MonoVM test variations#25908
Conversation
Re-enable MonoVM test coverage by setting DOTNET_MONOVM_SUPPORTED=1 so the MonoVM test variations run again, keeping signal that the test apps still build and run on Mono. The MonoVM variation also opts out of the NETSDK1242 check so the net11.0 Mono build proceeds. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This PR restores MonoVM test-variation coverage by enabling the Mono runtime variations in the test harness configuration and ensuring the |monovm| MSBuild variation can build on net11.0 by bypassing the SDK’s unsupported-runtime check.
Changes:
- Enable MonoVM test variations by setting
DOTNET_MONOVM_SUPPORTED=1inMake.config. - For the
|monovm|test variation, set_DisableCheckForUnsupportedMonoMobileRuntime=trueto opt out ofNETSDK1242and allow Mono builds to proceed onnet11.0.
Show a summary per file
| File | Description |
|---|---|
tests/common/test-variations.csproj |
Adds an opt-out MSBuild property so the ` |
Make.config |
Turns MonoVM test-variation support back on via DOTNET_MONOVM_SUPPORTED=1, re-enabling MonoVM-related variations in the harness. |
Copilot's findings
- Files reviewed: 2/2 changed files
- Comments generated: 0
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
🔥 [CI Build #87e866e] Test results 🔥Test results❌ Tests failed on VSTS: test results 0 tests crashed, 8 tests failed, 251 tests passed. Failures❌ dotnettests tests (iOS)1 tests failed, 0 tests passed.Failed tests
Html Report (VSDrops) Download ❌ dotnettests tests (MacCatalyst)1 tests failed, 0 tests passed.Failed tests
Html Report (VSDrops) Download ❌ dotnettests tests (tvOS)1 tests failed, 0 tests passed.Failed tests
Html Report (VSDrops) Download ❌ monotouch tests (iOS)1 tests failed, 23 tests passed.Failed tests
Html Report (VSDrops) Download ❌ monotouch tests (tvOS)1 tests failed, 23 tests passed.Failed tests
Html Report (VSDrops) Download ❌ windows tests2 tests failed, 1 tests passed.Failed tests
Html Report (VSDrops) Download ❌ Tests on macOS Tahoe (26) tests1 tests failed, 4 tests passed.Failed tests
Html Report (VSDrops) Download Successes✅ assembly-processing: All 1 tests passed. Html Report (VSDrops) Download macOS tests✅ Tests on macOS Sonoma (14): All 5 tests passed. Html Report (VSDrops) Download Linux Build VerificationPipeline on Agent |
The MonoVM test suite is gated on DOTNET_MONOVM_SUPPORTED. When it is enabled, the Mono unit-test builds set UseMonoRuntime=true but did not pass _DisableCheckForUnsupportedMonoMobileRuntime, so the net11.0 Mono builds failed the NETSDK1242 check. Inject the opt-out centrally whenever a Mono build runs. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ [PR Build #75bedbf] Build passed (Build macOS tests) ✅Pipeline on Agent |
✅ [PR Build #75bedbf] Build passed (Detect API changes) ✅Pipeline on Agent |
✅ API diff for current PR / commitNET (empty diffs)✅ API diff vs stableNET (empty diffs)ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
The DotNetWatch test builds via 'dotnet watch', which reads UseMonoRuntime from an environment variable rather than going through DotNet.AssertBuild. Add the _DisableCheckForUnsupportedMonoMobileRuntime opt-out to the same environment so the Mono variation builds succeed. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
✅ [PR Build #872b341] Build passed (Build packages) ✅Pipeline on Agent |
Re-enables MonoVM test coverage by setting
DOTNET_MONOVM_SUPPORTED=1inMake.config, so the MonoVM test variations run again and we keep signal that the test apps still build and run on Mono.