-
Notifications
You must be signed in to change notification settings - Fork 6.1k
Coerce copilot to avoid emdash everywhere #52978
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
adegeo
wants to merge
1
commit into
main
Choose a base branch
from
adegeo/copilot
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+3
−0
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -230,6 +230,9 @@ When editing, focus on these areas in order of priority: | |||||||||||||
| - ALWAYS use one space after periods, colons, question marks | ||||||||||||||
| - ALWAYS use no spaces around dashes: "Use pipelines—logical groups—to consolidate" | ||||||||||||||
| - ALWAYS add blank lines around markdown elements (don't add extra if they exist) | ||||||||||||||
| - TRY to avoid emdash and the various alternative dash characters; try to use other punctuation or formatting to achieve the same effect. Choose words over characters when possible | ||||||||||||||
| - OK to use compound adjectives with hyphens | ||||||||||||||
| - OK to use emdash mid-sentence for a clause or example; use sparingly | ||||||||||||||
|
Comment on lines
+233
to
+235
|
||||||||||||||
| - TRY to avoid emdash and the various alternative dash characters; try to use other punctuation or formatting to achieve the same effect. Choose words over characters when possible | |
| - OK to use compound adjectives with hyphens | |
| - OK to use emdash mid-sentence for a clause or example; use sparingly | |
| - TRY to avoid em dash and the various alternative dash characters; try to use other punctuation or formatting to achieve the same effect. Choose words over characters when possible | |
| - OK to use compound adjectives with hyphens | |
| - OK to use an em dash (—) mid-sentence for a clause or example; use sparingly |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new guidance on em dashes conflicts with the existing mandatory rule immediately above it. You currently say to "ALWAYS use no spaces around dashes" (with an em dash example), then "TRY to avoid" em dashes, then "OK to use" em dashes. Please consolidate/reword so the rules are consistent (for example: avoid em dashes where possible; if you must use an em dash, don’t include spaces around it; hyphens in compound modifiers are fine). Also consider naming the specific dash characters (em dash vs en dash) so the instruction is unambiguous.