Enable nullable reference types in AndroidDiskInformation.cs#11813
Merged
simonrozsival merged 2 commits intoJun 30, 2026
Merged
Conversation
Co-authored-by: jonathanpeppers <840039+jonathanpeppers@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Enable nullable reference types in AndroidDiskInformation.cs
Enable nullable reference types in AndroidDiskInformation.cs
Jun 30, 2026
simonrozsival
approved these changes
Jun 30, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR opts AndroidDiskInformation.cs into nullable reference types to improve compile-time null safety in the signed Mono.AndroidTools assembly, without changing runtime behavior.
Changes:
- Enabled nullable annotations via
#nullable enable. - Updated local variables that receive
StringReader.ReadLine()results fromstringtostring?in the parsing helpers.
Show a summary per file
| File | Description |
|---|---|
| src/Mono.AndroidTools/AndroidDiskInformation.cs | Enables NRT and aligns ReadLine() locals with string? to avoid nullable warnings and improve flow analysis. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 1
jonathanpeppers
approved these changes
Jun 30, 2026
rolfbjarne
approved these changes
Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
src/Mono.AndroidTools/AndroidDiskInformation.csships in the signedMono.AndroidToolsassembly but was nullable-oblivious. This opts the file into nullable reference types for compile-time null-safety with no runtime or API change.Changes
#nullable enableto the top of the file.slocals inParseNewFormatandParseOldFormatfromstringtostring?, matchingStringReader.ReadLine()'sstring?return. Flow analysis already narrowssto non-null inside thewhile ((s = reader.ReadLine ()) != null)bodies.Annotation-only: no
!operator, noArgumentNullException.ThrowIfNull(the project targetsnetstandard2.0), and public signatures (FromDfOutput,InternalSpace,ExternalSpace) are unchanged.