Update nullable review rule to check project-level setting#11073
Open
jonathanpeppers wants to merge 2 commits intomainfrom
Open
Update nullable review rule to check project-level setting#11073jonathanpeppers wants to merge 2 commits intomainfrom
jonathanpeppers wants to merge 2 commits intomainfrom
Conversation
Skip flagging missing per-file #nullable enable when the project's .csproj already has <Nullable>enable</Nullable>. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the repository’s AI/code review checklist to avoid incorrectly flagging missing per-file #nullable enable directives when nullable reference types are already enabled at the project level.
Changes:
- Adjusts the “
#nullable enable” rule to exempt projects that already set<Nullable>enable</Nullable>in their project file.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skip flagging missing per-file
#nullable enablewhen the project's.csprojalready has<Nullable>enable</Nullable>.Found during PR #10862 review —
src/Microsoft.Android.Run/AdbHelper.cswas flagged for missing#nullable enablebut the project already enables it at the project level.