Conversation
There was a problem hiding this comment.
Pull request overview
Updates pipeline version variables to move Microsoft.Data.SqlClient (MDS) builds to the 7.1.0 / 7.1.0-preview1 line.
Changes:
- Bump OneBranch official pipeline MDS GA version to
7.1.0and preview version to7.1.0-preview1.$(Build.BuildNumber). - Bump CI pipeline MDS package version to
7.1.0.$(Build.BuildNumber)-ci.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| eng/pipelines/onebranch/variables/common-variables.yml | Updates official/OneBranch MDS GA + preview package version variables. |
| eng/pipelines/libraries/ci-build-variables.yml | Updates CI MDS package version variable used by PR/CI pipelines. |
Comments suppressed due to low confidence (1)
eng/pipelines/onebranch/variables/common-variables.yml:95
mdsAssemblyFileVersionis still set to7.0.0.$(assemblyBuildNumber)whilemdsPackageVersion/mdsPackagePreviewVersionare now7.1.0. This makes the DLL FileVersion lag the package version (and can be confusing for validation/support scenarios). Consider bumpingmdsAssemblyFileVersionto7.1.0.$(assemblyBuildNumber)for consistency with the new 7.1 line.
value: 7.1.0-preview1.$(Build.BuildNumber)
# The AssemblyFileVersion for all assemblies in the MDS package.
- name: mdsAssemblyFileVersion
value: 7.0.0.$(assemblyBuildNumber)
You can also share your feedback on Copilot code review. Take the survey.
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## main #4054 +/- ##
==========================================
- Coverage 75.42% 65.62% -9.80%
==========================================
Files 280 275 -5
Lines 43834 65825 +21991
==========================================
+ Hits 33060 43197 +10137
- Misses 10774 22628 +11854
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
paulmedynski
left a comment
There was a problem hiding this comment.
We will also want:
- All of the other package versions bumped as well (Azure 1.1.0-preview1, etc).
- The csproj-based versions bumped.
No description provided.