Skip to content

Update sdk version and switch to System.Composition.#4052

Merged
mdaigle merged 1 commit intomainfrom
dev/mdaigle/version-bumps
Mar 16, 2026
Merged

Update sdk version and switch to System.Composition.#4052
mdaigle merged 1 commit intomainfrom
dev/mdaigle/version-bumps

Conversation

@mdaigle
Copy link
Contributor

@mdaigle mdaigle commented Mar 16, 2026

System.Composition is still actively maintained: https://www.nuget.org/packages/System.Composition
Validated that this addresses component governance warnings: https://sqlclientdrivers.visualstudio.com/ADO.Net/_git/dotnet-sqlclient/pullrequest/7114

@mdaigle mdaigle requested a review from a team as a code owner March 16, 2026 17:59
Copilot AI review requested due to automatic review settings March 16, 2026 17:59
@github-project-automation github-project-automation bot moved this to To triage in SqlClient Board Mar 16, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the tooling dependencies used by the GenAPI-related projects by moving from the legacy Microsoft.Composition package to the actively maintained System.Composition, and bumps the pinned .NET 10 SDK patch version used by builds/CI.

Changes:

  • Replace Microsoft.Composition with System.Composition in the GenAPI CCI extensions project.
  • Update centralized tool package versions to include System.Composition (and drop Microsoft.Composition).
  • Bump global.json SDK from 10.0.103 to 10.0.104.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
tools/GenAPI/Microsoft.Cci.Extensions/Microsoft.Cci.Extensions.csproj Switches MEF dependency to System.Composition for the CCI extensions tool project.
tools/Directory.Packages.props Central package versioning updated to use System.Composition instead of Microsoft.Composition.
global.json Updates the pinned .NET SDK patch version used by dotnet CLI and CI.

You can also share your feedback on Copilot code review. Take the survey.

@mdaigle mdaigle added this to the 7.0.0 milestone Mar 16, 2026
@cheenamalhotra cheenamalhotra moved this from To triage to In review in SqlClient Board Mar 16, 2026
@codecov
Copy link

codecov bot commented Mar 16, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.15%. Comparing base (00b77cd) to head (bafbe81).
⚠️ Report is 3 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (00b77cd) and HEAD (bafbe81). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (00b77cd) HEAD (bafbe81)
CI-SqlClient 2 0
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4052      +/-   ##
==========================================
- Coverage   75.42%   68.15%   -7.27%     
==========================================
  Files         280      275       -5     
  Lines       43834    66924   +23090     
==========================================
+ Hits        33060    45613   +12553     
- Misses      10774    21311   +10537     
Flag Coverage Δ
CI-SqlClient ?
PR-SqlClient-Project 68.15% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mdaigle mdaigle merged commit 48b8262 into main Mar 16, 2026
302 of 304 checks passed
@mdaigle mdaigle deleted the dev/mdaigle/version-bumps branch March 16, 2026 20:29
@github-project-automation github-project-automation bot moved this from In review to Done in SqlClient Board Mar 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants