Skip to content

Change dry-run to push to NuGet Test/QA environment#4032

Merged
cheenamalhotra merged 5 commits intomainfrom
dev/paul/nuget-qa
Mar 16, 2026
Merged

Change dry-run to push to NuGet Test/QA environment#4032
cheenamalhotra merged 5 commits intomainfrom
dev/paul/nuget-qa

Conversation

@paulmedynski
Copy link
Contributor

@paulmedynski paulmedynski commented Mar 11, 2026

Description

Changes the OneBranch pipelines to push to the NuGet Test/QA environment rather than using a dry-run concept.

  • Non-Official pipeline always pushes to NuGet Test/QA.
  • Official has a top-level parameter to choose NuGet Prod or Test/QA.
  • Stage and job display names clearly indicate where packages will be pushed.

Testing

Manual runs of the OneBranch pipelines wil confirm:

- Updated OneBranch pipelines to use the NuGet Test/QA service instead of the dry run concept.
@paulmedynski paulmedynski added this to the 7.0.0 milestone Mar 11, 2026
@paulmedynski paulmedynski requested a review from a team as a code owner March 11, 2026 14:29
@paulmedynski paulmedynski added the Area\Engineering Use this for issues that are targeted for changes in the 'eng' folder or build systems. label Mar 11, 2026
Copilot AI review requested due to automatic review settings March 11, 2026 14:29
@github-project-automation github-project-automation bot moved this to To triage in SqlClient Board Mar 11, 2026
@paulmedynski paulmedynski moved this from To triage to In review in SqlClient Board Mar 11, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the OneBranch release pipelines to remove the “dry run” behavior and instead push packages to a NuGet Test/QA target by default, with the Official pipeline able to switch between Test and Production.

Changes:

  • Add separate NuGet service connection variables for Production vs Test.
  • Replace isDryRun with releaseToProduction and wire the release stage/job display names to reflect the target feed.
  • Remove dry-run behavior from the publish job template and always perform NuGetCommand@2 push.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
eng/pipelines/onebranch/variables/common-variables.yml Splits NuGet service connection into Prod/Test variables.
eng/pipelines/onebranch/stages/release-stages.yml Introduces releaseToProduction, selects service connection, and updates stage/job labeling.
eng/pipelines/onebranch/sqlclient-official.yml Adds top-level releaseToProduction parameter and passes it to release template.
eng/pipelines/onebranch/sqlclient-non-official.yml Forces non-official releases to target the Test feed.
eng/pipelines/onebranch/jobs/publish-nuget-package-job.yml Removes dry-run listing path and always pushes packages.

You can also share your feedback on Copilot code review. Take the survey.

Copy link
Contributor

@mdaigle mdaigle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Will watch for the example pipeline run.

- Added doagnostics to release jobs to see what packages will be pushed.
Copilot AI review requested due to automatic review settings March 12, 2026 11:07
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.


You can also share your feedback on Copilot code review. Take the survey.

- Moved NuGet service connection names into release-stages just like the other release environment values.
@paulmedynski paulmedynski modified the milestones: 7.0.0, 7.1.0-preview1 Mar 12, 2026
Copy link
Contributor

@priyankatiwari08 priyankatiwari08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Its good to test the actual push behaviour than simply relying on dry-run before production release :)

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.


You can also share your feedback on Copilot code review. Take the survey.

Copy link
Contributor

@mdaigle mdaigle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Started a new run to verify change to logging package release: https://sqlclientdrivers.visualstudio.com/ADO.Net/_build/results?buildId=143839&view=results

@cheenamalhotra cheenamalhotra modified the milestones: 7.1.0-preview1, 7.0.0 Mar 16, 2026
@cheenamalhotra cheenamalhotra merged commit 6370073 into main Mar 16, 2026
9 checks passed
@cheenamalhotra cheenamalhotra deleted the dev/paul/nuget-qa branch March 16, 2026 18:15
@github-project-automation github-project-automation bot moved this from In review to Done in SqlClient Board Mar 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area\Engineering Use this for issues that are targeted for changes in the 'eng' folder or build systems.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants