Change dry-run to push to NuGet Test/QA environment#4032
Change dry-run to push to NuGet Test/QA environment#4032cheenamalhotra merged 5 commits intomainfrom
Conversation
- Updated OneBranch pipelines to use the NuGet Test/QA service instead of the dry run concept.
There was a problem hiding this comment.
Pull request overview
Updates the OneBranch release pipelines to remove the “dry run” behavior and instead push packages to a NuGet Test/QA target by default, with the Official pipeline able to switch between Test and Production.
Changes:
- Add separate NuGet service connection variables for Production vs Test.
- Replace
isDryRunwithreleaseToProductionand wire the release stage/job display names to reflect the target feed. - Remove dry-run behavior from the publish job template and always perform
NuGetCommand@2 push.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| eng/pipelines/onebranch/variables/common-variables.yml | Splits NuGet service connection into Prod/Test variables. |
| eng/pipelines/onebranch/stages/release-stages.yml | Introduces releaseToProduction, selects service connection, and updates stage/job labeling. |
| eng/pipelines/onebranch/sqlclient-official.yml | Adds top-level releaseToProduction parameter and passes it to release template. |
| eng/pipelines/onebranch/sqlclient-non-official.yml | Forces non-official releases to target the Test feed. |
| eng/pipelines/onebranch/jobs/publish-nuget-package-job.yml | Removes dry-run listing path and always pushes packages. |
You can also share your feedback on Copilot code review. Take the survey.
- Fixed variable expansion issues.
mdaigle
left a comment
There was a problem hiding this comment.
Looks good. Will watch for the example pipeline run.
- Added doagnostics to release jobs to see what packages will be pushed.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.
You can also share your feedback on Copilot code review. Take the survey.
- Moved NuGet service connection names into release-stages just like the other release environment values.
priyankatiwari08
left a comment
There was a problem hiding this comment.
Looks good to me. Its good to test the actual push behaviour than simply relying on dry-run before production release :)
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.
You can also share your feedback on Copilot code review. Take the survey.
mdaigle
left a comment
There was a problem hiding this comment.
Started a new run to verify change to logging package release: https://sqlclientdrivers.visualstudio.com/ADO.Net/_build/results?buildId=143839&view=results
Description
Changes the OneBranch pipelines to push to the NuGet Test/QA environment rather than using a dry-run concept.
Testing
Manual runs of the OneBranch pipelines wil confirm: