Expose copy default transient error list

[MatthiasHuygelen]

Description

The default set of transient error codes is private. This seems to make it difficult to extend error codes without copy/pasting the base set from this repository. So we expose a copy.

Issues

#2342

[Copilot]

Pull request overview

This PR exposes the previously private default transient error list as a public property to address issue #2342, allowing consumers to extend the error code list without needing to copy/paste the base set from the repository.

Changes:

• Adds a new public property DefaultTransientErrors to SqlConfigurableRetryFactory that returns a read-only copy of the default transient error list
• Removes duplicated error list from test helper class RetryLogicTestHelper and migrates to use the new public API
• Adds XML documentation for the new public property and documents additional error codes (64, 20, 0, -2, 207, 18456, 42108, 42109)

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File	Description
src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/Reliability/SqlConfigurableRetryFactory.cs	Adds public DefaultTransientErrors property that returns a ReadOnlyCollection<int> copy of the private transient error list; adds missing error codes to the private list
src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/RetryLogic/RetryLogicTestHelper.cs	Removes duplicated private error list and updates code to reference the new public SqlConfigurableRetryFactory.DefaultTransientErrors property
doc/snippets/Microsoft.Data.SqlClient/SqlConfigurableRetryFactory.xml	Adds XML documentation for the new property and documents the previously undocumented error codes

[MatthiasHuygelen]

@MatthiasHuygelen please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@dotnet-policy-service agree [company="{your company}"]

Options:

• (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.

@dotnet-policy-service agree

• (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.

@dotnet-policy-service agree company="Microsoft"

Contributor License Agreement

@dotnet-policy-service agree

[paulmedynski]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 2 pipeline(s).

[paulmedynski]

Thanks for the submission. The team will need to discuss the public API changes, and I have one implementation suggestion.

[Copilot]

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 6 comments.

[paulmedynski]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 2 pipeline(s).

[paulmedynski]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 2 pipeline(s).

[Copilot]

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

[cheenamalhotra]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 2 pipeline(s).

[Copilot]

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

[David-Engel]

@paulmedynski
IntrinsicTransientErrors sounds odd to me. To philosophical maybe? How about InitialTransientErrors?

I also considered BaselineTransientErrors, CommonTransientErrors, KnownTransientErrors, and SuggestedTransientErrors.

Open to other suggestions, too.

[MatthiasHuygelen]

@paulmedynski IntrinsicTransientErrors sounds odd to me. To philosophical maybe? How about InitialTransientErrors?

I also considered BaselineTransientErrors, CommonTransientErrors, KnownTransientErrors, and SuggestedTransientErrors.

Open to other suggestions, too.

@paulmedynski So what should I do?

[paulmedynski]

BaselineTransientErrors sounds good to me!

[paulmedynski]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 2 pipeline(s).

[paulmedynski]

Thanks for making the changes I requested. A few small tweaks left.

[paulmedynski]

@MatthiasHuygelen - I broke PR pipeline runs for forked repos with #3928, and #3950 should fix it. Once that merges, can you rebase/merge main? Then I will kick off the PR pipeline runs.

[paulmedynski]

@MatthiasHuygelen - Can you merge/rebase main? #3950 has been merged and should fix the pipeline issues we're seeing here.

[paulmedynski]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 2 pipeline(s).

[Copilot]

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Comments suppressed due to low confidence (1)

doc/snippets/Microsoft.Data.SqlClient/SqlConfigurableRetryFactory.xml:126

• The <exception cref="T:System.ArgumentNullException"> text uses Markdown-style backticks around the parameter name (retryLogicOption). For consistency with the rest of the XML docs (and to ensure tooling formats it correctly), this should use <paramref name="retryLogicOption" /> instead of backticks.

      <exception cref="T:System.ArgumentNullException">
        If the `retryLogicOption` parameter was null.
      </exception>

[Copilot]

BaselineTransientErrors docs say “inner transient error list”, but this is now a public baseline list meant for reuse by applications. Consider renaming this text to “baseline/default transient error list” (and, if relevant, mention that callers should treat it as a baseline to copy/extend rather than a stable contract).

Suggested change

	The following table shows the inner transient error list.
	</para>
	The following table shows the baseline/default transient error list used by the built-in retry providers.
	</para>
	<para>
	Callers should treat this list as a starting point to copy and extend for their own retry logic, rather than as a stable contract that will remain unchanged.
	</para>