Skip to content

Conversation

@flcdrg
Copy link
Contributor

@flcdrg flcdrg commented Jan 17, 2026

"NOT NULL NULL" is not valid T-SQL. Given it refers to the previous type, allowing this column to be nullable seems to be what was intended.

"NOT NULL NULL" is not valid T-SQL. Given it refers to the previous type, allowing this column to be nullable seems to be what was intended.
Copy link
Member

@roji roji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting the error, but I don't see any reason for this to be nullable, given that ShippingAddress just above is non-nullable and they configured exactly the same (plus the section just above - for table splitting - shows two non-nullable properties.

@roji roji enabled auto-merge (squash) January 18, 2026 10:21
@roji roji merged commit 917d992 into dotnet:main Jan 18, 2026
4 checks passed
@flcdrg
Copy link
Contributor Author

flcdrg commented Jan 18, 2026

But it isn't!

If you refer to the most recent definition above it is defined like this:

public class Customer
{
    ...

    public Address ShippingAddress { get; set; }
    public Address? BillingAddress { get; set; }
}

@flcdrg flcdrg deleted the patch-1 branch January 18, 2026 23:04
roji added a commit to roji/EntityFramework.Docs that referenced this pull request Jan 20, 2026
@roji
Copy link
Member

roji commented Jan 20, 2026

Oops, you're right - sorry about that. Submitted #5250 to correct it.

roji added a commit that referenced this pull request Jan 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants