Skip to content

chore: Fix CodeFixer tests error that occurred on windows#3082

Merged
timcassell merged 1 commit intodotnet:masterfrom
filzrev:chore-fix-codefixer-tests-on-windows
Apr 14, 2026
Merged

chore: Fix CodeFixer tests error that occurred on windows#3082
timcassell merged 1 commit intodotnet:masterfrom
filzrev:chore-fix-codefixer-tests-on-windows

Conversation

@filzrev
Copy link
Copy Markdown
Contributor

@filzrev filzrev commented Apr 13, 2026

This PR fix errors that occurred by CRLF/LF differences on windows environment.

Currently AsyncBenchmarkCodeFixProviderTests failed when following conditions are met.

  1. Running tests on Windows environment.
  2. git autocrlf config is disabled. (Source code is checked out as LF)

As far as I've confirmed, there is no setting to ignore line endings on Microsoft.CodeAnalysis.Testing library side.
So manually normalize expected/actual values with ReplaceLineEndings API.
dotnet/roslyn-sdk#983

@filzrev filzrev marked this pull request as ready for review April 13, 2026 07:05
@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines:
3 pipeline(s) were filtered out due to trigger conditions.

1 similar comment
@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines:
3 pipeline(s) were filtered out due to trigger conditions.

@filzrev filzrev force-pushed the chore-fix-codefixer-tests-on-windows branch from 3ba7ab6 to 17225d9 Compare April 14, 2026 12:14
@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines:
3 pipeline(s) were filtered out due to trigger conditions.

@timcassell timcassell added this to the v0.16.0 milestone Apr 14, 2026
@timcassell timcassell merged commit 7113f37 into dotnet:master Apr 14, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants