docs: fix three relative links that never resolved - #37627
Merged
Merged
Conversation
All three were written as if the containing file sat at the repo root. `.specify/memory/constitution.md` linked `docs/core/SECURITY_PRINCIPLES.md` and `docs/core/ROLLBACK_UNSAFE_CATEGORIES.md`, which resolve to `.specify/memory/docs/core/...`. The constitution is loaded by every skill and both targets are Critical Rules material, so the two rules it most wants a reader to follow were the two it could not reach. Now `../../docs/core/`. `core-web/CLAUDE.md:106` linked `docs/frontend/STYLING_STANDARDS.md#form-fields`, resolving to `core-web/docs/frontend/...`. Line 142 of the same file already used `../docs/frontend/` for a sibling doc, so this now matches the convention already in the file. The `#form-fields` anchor exists (STYLING_STANDARDS.md:149). Refs #37577 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
10 tasks
Contributor
|
Claude finished @fabrizzio-dotCMS's task in 28s —— View job Review complete
I verified each edited link by re-resolving it from its file's location:
New IssuesNo issues found. All six links across the two changed files resolve to real files, and the anchor matches its target heading. The fix is correct, minimal, and consistent with existing conventions. The out-of-scope call is reasonable — keeping this PR to the three links #37577 names and routing the other 77 to the #37580 backlog is the right scoping. An automated markdown link check would be the durable fix. · |
jcastro-dotcms
approved these changes
Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixes the three broken documentation links found while auditing Scout's slice for #37577. All three share one cause: the link was written as if the containing file sat at the repo root.
.specify/memory/constitution.md:39docs/core/SECURITY_PRINCIPLES.md.specify/memory/docs/core/…../../docs/core/….specify/memory/constitution.md:47docs/core/ROLLBACK_UNSAFE_CATEGORIES.md.specify/memory/docs/core/…../../docs/core/…core-web/CLAUDE.md:106docs/frontend/STYLING_STANDARDS.md#form-fieldscore-web/docs/frontend/…../docs/frontend/…The constitution is loaded by every skill, and both of its targets are Critical Rules material — so the two rules it most wants a reader to follow were the two it could not reach.
For
core-web/CLAUDE.md, line 142 of the same file already used../docs/frontend/for a sibling doc, so this just matches the convention already there. The#form-fieldsanchor exists atSTYLING_STANDARDS.md:149.Out of scope, worth knowing
A repo-wide sweep of all 539 tracked
.mdfiles turned up 77 broken relative links beyond these three. None are indocs/— that tree is clean. The breakdown:specs/— mostly sibling references (./research.md,../data-model.md) in spec working directories where the referenced artifact was never created or has since moved..github/— including 8 written with a leading slash (/CLAUDE.md,/CONTRIBUTING.md), which does not resolve on github.com.README.md,core-web/libs/portlets/edit-ema/ARCHITECTURE.md, andtest-jmeter/.Left alone deliberately: this PR is scoped to the three links #37577 names, and
specs/is a different kind of artifact with different owners. Flagging it for the gap backlog (#37580) instead — an automated link check would catch all 77 and stop them coming back, which is the same argument as the reachability check in #37578.Testing
Documentation only. Every link in both changed files was re-resolved after the edit; all six now point at real files, and the one anchor reference was confirmed against its target heading.
Refs #37577
🤖 Generated with Claude Code
This PR fixes: #37577