Repository navigation
feat(pass)!: authorize before removing secrets - #672
Merged
Merged
Conversation
joe0BAB
force-pushed
the
feat/get-reveal
branch
from
October 5, 2026 15:12
cf52489 to
7b9e649
Compare
rm asks the engine once for every secret it is about to delete and removes nothing when access is denied. RmCommand takes the same client options as get and run and returns an error. The Long description moves into rm_long.md, and get shares the new authorizeAccess helper.
joe0BAB
force-pushed
the
feat/get-reveal
branch
from
October 6, 2026 06:48
7b9e649 to
d4349c6
Compare
joe0BAB
marked this pull request as ready for review
October 6, 2026 06:49
docker-agent
reviewed
Oct 6, 2026
docker-agent
left a comment
docker-agent
left a comment
Contributor
There was a problem hiding this comment.
Assessment: 🟢 APPROVE
Benehiko
approved these changes
Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rm asks the engine once for every secret it is about to delete and removes nothing when access is denied. RmCommand takes the same client options as get and run and returns an error. The Long description moves into rm_long.md, and get shares the new authorizeAccess helper.
Closes docker/secrets-engine-private#729.