Repository navigation
refactor(pass): extract get docs and engine client plumbing - #667
Merged
Merged
Conversation
Moves the Long description of `get` into get_long.md and adds a get_example.md, matching the pattern used by `set` and `run`.
joe0BAB
force-pushed
the
feat/get-reveal
branch
from
October 5, 2026 13:29
eb46194 to
e35964a
Compare
joe0BAB
changed the title
joe0BAB
force-pushed
the
feat/get-reveal
branch
from
October 5, 2026 13:41
e35964a to
644610b
Compare
joe0BAB
marked this pull request as ready for review
October 5, 2026 13:42
docker-agent
reviewed
Oct 5, 2026
docker-agent
left a comment
docker-agent
left a comment
Contributor
There was a problem hiding this comment.
Assessment: 🟢 APPROVE
Benehiko
reviewed
Oct 5, 2026
Moves the client options, connection setup, preflight ping and the authorize check into client.go so other commands can reuse them. RunOption stays as an alias of ClientOption.
joe0BAB
force-pushed
the
feat/get-reveal
branch
from
October 5, 2026 13:58
644610b to
3bb9bb1
Compare
Benehiko
approved these changes
Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Extract
getdocs to embedded markdownMoves the Long description of
getintoget_long.mdand adds aget_example.md, matching the patternsetand
runalready use. The rendered help text is unchanged.Extract engine client plumbing from
runMoves the client options, connection setup, preflight ping and the authorize check from
run.gointo a newclient.go, so other commands can reuse them:ClientOptionwithWithSocketPath,WithTimeoutandWithResponseTimeout.RunOptionstays as an alias,so existing callers compile unchanged.
connectEnginebuilds the client and keeps the existing rule: ping the engine first when requests areunbounded, so a dead socket fails fast instead of hanging.
authorizewraps the Authorize call and maps a deny toErrAccessDenied.authorizeEnvdelegates to it. Ithas one caller today;
get --revealwill be the second.