-
Notifications
You must be signed in to change notification settings - Fork 85
(WIP) - Added layer wise reporting on push #571
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @MetsysEht, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the image push functionality by introducing a more detailed, layer-wise progress reporting mechanism. It allows for streaming progress updates via a standard Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces layer-wise progress reporting for image pushes. The implementation creates a progress reporter for each layer. My review focuses on ensuring the new progress reporting logic is correct and robust. I've identified a few issues related to incorrect progress value calculations, which could lead to a confusing user experience, and a potential goroutine leak due to improper lifecycle management of the progress reporter. The suggested changes aim to fix these issues to make the feature reliable.
b365dca to
afc4b01
Compare
afc4b01 to
4f1834e
Compare
Only initialize standalone runner when --push is not used. When pushing to registry, no local runner is needed. This allows `docker model package --push` to work without Docker Desktop or a running model runner. Signed-off-by: Dorin Geman <dorin.geman@docker.com>
Add nil check for modelRunner before calling EngineKind() to prevent panic in test scenarios where packageModel is called directly without going through the root command's PersistentPreRunE initialization. Signed-off-by: Dorin Geman <dorin.geman@docker.com>
Add support for both DOCKER_USERNAME/DOCKER_PASSWORD and the existing DOCKER_HUB_USER/DOCKER_HUB_PASSWORD environment variables in DefaultKeychain. This change is part of an effort to remove mdltool, which had its own env var handling for DOCKER_USERNAME/DOCKER_PASSWORD. By moving this support into DefaultKeychain, registry clients automatically pick up credentials without requiring explicit configuration. Signed-off-by: Dorin Geman <dorin.geman@docker.com>
Thanks to docker#567 and docker#568. Tested in https://github.com/docker/model-publisher/pull/77. Signed-off-by: Dorin Geman <dorin.geman@docker.com>
…ting options Replace WithTransport, WithUserAgent, WithPlainHTTP, and WithRegistryAuth options with a single WithRegistryClient option. This eliminates the duplicate registry client creation - callers now create one registry client and pass it to both the distribution client and use it directly. Signed-off-by: Dorin Geman <dorin.geman@docker.com>
Signed-off-by: Dorin Geman <dorin.geman@docker.com>
Signed-off-by: Dorin Geman <dorin.geman@docker.com>
The /set system command allows users to set or update the system message during interactive sessions. The system prompt is now included in the message history sent to the chat endpoint, enabling customized behavior for the AI assistant. Signed-off-by: Eric Curtin <eric.curtin@docker.com>
Bumps the github-actions group with 1 update: [actions/setup-go](https://github.com/actions/setup-go). Updates `actions/setup-go` from 6.1.0 to 6.2.0 - [Release notes](https://github.com/actions/setup-go/releases) - [Commits](actions/setup-go@4dc6199...7a3fe6c) --- updated-dependencies: - dependency-name: actions/setup-go dependency-version: 6.2.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: github-actions ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps the go-modules-cli group in /cmd/cli with 2 updates: [github.com/docker/cli](https://github.com/docker/cli) and [github.com/olekukonko/tablewriter](https://github.com/olekukonko/tablewriter). Updates `github.com/docker/cli` from 29.1.4+incompatible to 29.1.5+incompatible - [Commits](docker/cli@v29.1.4...v29.1.5) Updates `github.com/olekukonko/tablewriter` from 1.1.2 to 1.1.3 - [Release notes](https://github.com/olekukonko/tablewriter/releases) - [Commits](olekukonko/tablewriter@v1.1.2...v1.1.3) --- updated-dependencies: - dependency-name: github.com/docker/cli dependency-version: 29.1.5+incompatible dependency-type: direct:production update-type: version-update:semver-patch dependency-group: go-modules-cli - dependency-name: github.com/olekukonko/tablewriter dependency-version: 1.1.3 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: go-modules-cli ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps the go-modules-root group with 1 update: [github.com/sirupsen/logrus](https://github.com/sirupsen/logrus). Updates `github.com/sirupsen/logrus` from 1.9.3 to 1.9.4 - [Release notes](https://github.com/sirupsen/logrus/releases) - [Changelog](https://github.com/sirupsen/logrus/blob/master/CHANGELOG.md) - [Commits](sirupsen/logrus@v1.9.3...v1.9.4) --- updated-dependencies: - dependency-name: github.com/sirupsen/logrus dependency-version: 1.9.4 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: go-modules-root ... Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Dorin Geman <dorin.geman@docker.com>
* feat(diffusers): implement diffusers backend for image generation * feat(diffusers): add support for DDUF (Diffusers Unified Format) file handling * feat(dduf): implement DDUF format support and enhance model loading * feat(dduf): calculate total size of files and add human-readable size format * feat(platform): restrict Diffusers support to Linux only until macOS distribution is designed * feat(diffusers): add support for DDUF file type handling in repository and config files * feat(diffusers): sanitize log output for Diffusers arguments * feat(docker): streamline Python server code copying in Dockerfile * feat(docker): specify exact versions for Python packages in Dockerfile * feat(model): add DDUF file support to packaging command and documentation * Update pkg/distribution/internal/bundle/unpack.go Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com> * refactor(dduf): replace formatDDUFSize with formatSize and clean up unused code * feat(docker): add support for building and running Diffusers Docker images * feat(client): add support for Diffusers format in GetSupportedFormats function * feat(docker): enhance GPU support for additional Docker image variants * feat: add support for image-generation mode in backend operations * feat(loader): support fallback for image-generation mode in runner config * feat(diffusers): initialize Diffusers backend in main.go * feat(diffusers): add error transformation for Python output and enhance backend error handling * fix(scripts/docker-run): conditionally add nvidia runtime flags Only add --gpus and --runtime=nvidia when the nvidia runtime is detected, allowing diffusers/sglang images to run on non-NVIDIA hosts. Signed-off-by: Dorin Geman <dorin.geman@docker.com> --------- Signed-off-by: Dorin Geman <dorin.geman@docker.com> Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com> Co-authored-by: Dorin Geman <dorin.geman@docker.com>
Signed-off-by: Dorin Geman <dorin.geman@docker.com>
No description provided.