Skip to content

Conversation

@MetsysEht
Copy link
Contributor

No description provided.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @MetsysEht, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the image push functionality by introducing a more detailed, layer-wise progress reporting mechanism. It allows for streaming progress updates via a standard io.Writer, improving the transparency and user experience during image uploads. The changes involve refactoring the core Write function to accept a progress writer and adapting the client-side calls accordingly.

Highlights

  • Refactored Progress Reporting: The image push operation has been refactored to support more granular, layer-wise progress reporting, providing better visibility into the upload status of individual layers.
  • io.Writer for Progress: The remote.Write function now accepts an io.Writer parameter, allowing external components to receive real-time progress updates during the image push.
  • Thread-Safe Writing: A new syncWriter type has been introduced to ensure thread-safe concurrent writes to the provided io.Writer, crucial for handling progress updates from multiple goroutines.
  • Client-Side Integration: The registry/client.go has been updated to integrate with the new remote.Write signature, passing its progressWriter directly and removing its previous direct dependency on the internal/progress package.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces layer-wise progress reporting for image pushes. The implementation creates a progress reporter for each layer. My review focuses on ensuring the new progress reporting logic is correct and robust. I've identified a few issues related to incorrect progress value calculations, which could lead to a confusing user experience, and a potential goroutine leak due to improper lifecycle management of the progress reporter. The suggested changes aim to fix these issues to make the feature reliable.

@MetsysEht MetsysEht force-pushed the Layer-wise-update-on-push branch from afc4b01 to 4f1834e Compare January 14, 2026 18:09
doringeman and others added 16 commits January 19, 2026 11:27
Only initialize standalone runner when --push is not used. When pushing to registry, no local runner is needed. This allows `docker model package --push` to work without Docker Desktop or a running model runner.

Signed-off-by: Dorin Geman <dorin.geman@docker.com>
Add nil check for modelRunner before calling EngineKind() to prevent panic in test scenarios where packageModel is called directly without going through the root command's PersistentPreRunE initialization.

Signed-off-by: Dorin Geman <dorin.geman@docker.com>
Add support for both DOCKER_USERNAME/DOCKER_PASSWORD and the existing DOCKER_HUB_USER/DOCKER_HUB_PASSWORD environment variables in DefaultKeychain.

This change is part of an effort to remove mdltool, which had its own env var handling for DOCKER_USERNAME/DOCKER_PASSWORD. By moving this support into DefaultKeychain, registry clients automatically pick up credentials without requiring explicit configuration.

Signed-off-by: Dorin Geman <dorin.geman@docker.com>
Thanks to docker#567 and docker#568. Tested in https://github.com/docker/model-publisher/pull/77.

Signed-off-by: Dorin Geman <dorin.geman@docker.com>
…ting options

Replace WithTransport, WithUserAgent, WithPlainHTTP, and WithRegistryAuth options with a single WithRegistryClient option. This eliminates the duplicate registry client creation - callers now create one registry client and pass it to both the distribution client and use it directly.

Signed-off-by: Dorin Geman <dorin.geman@docker.com>
Signed-off-by: Dorin Geman <dorin.geman@docker.com>
Signed-off-by: Dorin Geman <dorin.geman@docker.com>
The /set system command allows users to set or update the system message
during interactive sessions. The system prompt is now included in the
message history sent to the chat endpoint, enabling customized behavior
for the AI assistant.

Signed-off-by: Eric Curtin <eric.curtin@docker.com>
Bumps the github-actions group with 1 update: [actions/setup-go](https://github.com/actions/setup-go).


Updates `actions/setup-go` from 6.1.0 to 6.2.0
- [Release notes](https://github.com/actions/setup-go/releases)
- [Commits](actions/setup-go@4dc6199...7a3fe6c)

---
updated-dependencies:
- dependency-name: actions/setup-go
  dependency-version: 6.2.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: github-actions
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps the go-modules-cli group in /cmd/cli with 2 updates: [github.com/docker/cli](https://github.com/docker/cli) and [github.com/olekukonko/tablewriter](https://github.com/olekukonko/tablewriter).


Updates `github.com/docker/cli` from 29.1.4+incompatible to 29.1.5+incompatible
- [Commits](docker/cli@v29.1.4...v29.1.5)

Updates `github.com/olekukonko/tablewriter` from 1.1.2 to 1.1.3
- [Release notes](https://github.com/olekukonko/tablewriter/releases)
- [Commits](olekukonko/tablewriter@v1.1.2...v1.1.3)

---
updated-dependencies:
- dependency-name: github.com/docker/cli
  dependency-version: 29.1.5+incompatible
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: go-modules-cli
- dependency-name: github.com/olekukonko/tablewriter
  dependency-version: 1.1.3
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: go-modules-cli
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps the go-modules-root group with 1 update: [github.com/sirupsen/logrus](https://github.com/sirupsen/logrus).


Updates `github.com/sirupsen/logrus` from 1.9.3 to 1.9.4
- [Release notes](https://github.com/sirupsen/logrus/releases)
- [Changelog](https://github.com/sirupsen/logrus/blob/master/CHANGELOG.md)
- [Commits](sirupsen/logrus@v1.9.3...v1.9.4)

---
updated-dependencies:
- dependency-name: github.com/sirupsen/logrus
  dependency-version: 1.9.4
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: go-modules-root
...

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Dorin Geman <dorin.geman@docker.com>
* feat(diffusers): implement diffusers backend for image generation

* feat(diffusers): add support for DDUF (Diffusers Unified Format) file handling

* feat(dduf): implement DDUF format support and enhance model loading

* feat(dduf): calculate total size of files and add human-readable size format

* feat(platform): restrict Diffusers support to Linux only until macOS distribution is designed

* feat(diffusers): add support for DDUF file type handling in repository and config files

* feat(diffusers): sanitize log output for Diffusers arguments

* feat(docker): streamline Python server code copying in Dockerfile

* feat(docker): specify exact versions for Python packages in Dockerfile

* feat(model): add DDUF file support to packaging command and documentation

* Update pkg/distribution/internal/bundle/unpack.go

Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>

* refactor(dduf): replace formatDDUFSize with formatSize and clean up unused code

* feat(docker): add support for building and running Diffusers Docker images

* feat(client): add support for Diffusers format in GetSupportedFormats function

* feat(docker): enhance GPU support for additional Docker image variants

* feat: add support for image-generation mode in backend operations

* feat(loader): support fallback for image-generation mode in runner config

* feat(diffusers): initialize Diffusers backend in main.go

* feat(diffusers): add error transformation for Python output and enhance backend error handling

* fix(scripts/docker-run): conditionally add nvidia runtime flags

Only add --gpus and --runtime=nvidia when the nvidia runtime is detected, allowing diffusers/sglang images to run on non-NVIDIA hosts.

Signed-off-by: Dorin Geman <dorin.geman@docker.com>

---------

Signed-off-by: Dorin Geman <dorin.geman@docker.com>
Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
Co-authored-by: Dorin Geman <dorin.geman@docker.com>
Signed-off-by: Dorin Geman <dorin.geman@docker.com>
@MetsysEht MetsysEht closed this Jan 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants