docs: fix tag/branch logic in Circle CI and GitLab environment examples#25135
Open
lacatoire wants to merge 1 commit into
Open
docs: fix tag/branch logic in Circle CI and GitLab environment examples#25135lacatoire wants to merge 1 commit into
lacatoire wants to merge 1 commit into
Conversation
The Circle CI example had inverted conditionals (it set the tag from the empty variable and used a GitLab variable in the branch echo), and the GitLab example printed echoes that didn't match the branch taken. Align each branch of the conditionals with its echo and use the provider's own variables. Fixes docker#25081 Fixes docker#25082
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Member
|
Hm.. linting failure looks unrelated, but legit? I suspect CI was outdated on #24134 |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
scout/integrations/environment/cli.md:tagfrom the empty variable) and the branch case echoed a GitLab variable ($CI_COMMIT_BRANCH). Each branch now uses the matching Circle CI variable.Fixes #25081
Fixes #25082