feat(tracing): add COMPOSE_OTEL_DEBUG to surface OTel internals - #14152
Open
htoyoda18 wants to merge 1 commit into
Open
feat(tracing): add COMPOSE_OTEL_DEBUG to surface OTel internals#14152htoyoda18 wants to merge 1 commit into
htoyoda18 wants to merge 1 commit into
Conversation
Signed-off-by: hiroto.toyoda <hiroto.toyoda@dena.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
OTel SDK/exporter internal errors (
otel.ErrorHandler) and the tracer shutdown/flush error inwrapRunEwere both always discarded, making it impossible to diagnose tracing issues (e.g. a misconfigured or unreachable OTLP endpoint) without instrumenting the code.Added
tracing.DebugEnabled(), gated on a newCOMPOSE_OTEL_DEBUGenvironment variable, and used it in both places:internal/tracing'sotel.ErrorHandlernow prints to stderr when enabled instead of always being a no-optracingShutdown(ctx)error incmd/cmdtrace/cmd_span.gois now printed to the command's stderr (dockerCli.Err()) when enabledDefault behavior (
COMPOSE_OTEL_DEBUGunset) is unchanged — tracing plumbing still never leaks into ordinary CLI output.Related issue
N/A
(not mandatory) A picture of a cute animal, if possible in relation to what you did
