metrics-addr is not experimental anymore since 20.10#4391
metrics-addr is not experimental anymore since 20.10#4391u1735067 wants to merge 1 commit intodocker:masterfrom
Conversation
|
Thank you for contributing! It appears your commit message is missing a DCO sign-off, We require all commit messages to have a There is no need to open a new pull request, but to fix this (and make CI pass), Unfortunately, it's not possible to do so through GitHub's web UI, so this needs You can find some instructions in the output of the DCO check (which can be found Steps to do so "roughly" come down to:
Sorry for the hassle (I wish GitHub would make this a bit easier to do), and let me know if you need help or more detailed instructions! |
You're welcome ; sorry about that, I'm currently only able to use the WebUI and I probably won't be able to do the sign-off (and squash the commits) until a few weeks. Since this is really a small change, feel free to take this change under your name if it can help 😊 |
See moby/moby@f337a8d Signed-off-by: Alexandre LEVAVASSEUR <alexandre+oss@13x.fr>
|
I don't know if this message is required, but the sign-off and squash have been done :) |
| Please note that this feature is still marked as experimental as metrics and metric | ||
| names could change while this feature is still in experimental. Please provide | ||
| feedback on what you would like to see collected in the API. | ||
|
|
There was a problem hiding this comment.
We may want to keep some wording about this.
The TL;DR is that we removed the experimental gate on the daemon side for the metrics socket, because we saw no strong motivation to require both the experimental option to be set, and setting the option for the metrics-address.
That said, naming of metrics may still change (also see moby/moby#27307); an initial set of metrics implemented, and the original plan was to add / change those based on feedback (we didn't get a lot of that, and I don't think here's been much activity around it).
There was a problem hiding this comment.
I'd say fine to remove this. The docs shouldn't discuss things that may or may not happen in the future.
- What I did
Removed obsolete phrases about
experimentalaspect ofmetrics-addr, see moby/moby@f337a8d- How to verify it
Preview the page docs/reference/commandline/dockerd.md of this commit
- Description for the changelog
Fix doc mentioning
metrics-addras stillexperimental- A picture of a cute animal (not mandatory but encouraged)
https://twitter.com/TweetsOfCats/status/1674110876863823891