Skip to content

Fix subagent logic#1637

Merged
dgageot merged 1 commit intodocker:mainfrom
krissetto:fix-subagent-logic
Feb 8, 2026
Merged

Fix subagent logic#1637
dgageot merged 1 commit intodocker:mainfrom
krissetto:fix-subagent-logic

Conversation

@krissetto
Copy link
Contributor

@krissetto krissetto commented Feb 7, 2026

Fixes subagent delegation and validates model outputs to be valid subagents when transfer_task is called

This fixes an agent being able to delegate to another agent which is not explicitly configured in its sub_agents list

… is called

Signed-off-by: Christopher Petito <chrisjpetito@gmail.com>
@krissetto krissetto requested a review from a team as a code owner February 7, 2026 15:54
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Complete ✅

I've completed the automated review of this PR. The changes look good - the validation logic correctly enforces that agents can only transfer tasks to their direct sub-agents.

Summary:

  • ✅ Validation logic is correct and well-tested
  • ✅ Error messages are clear and helpful
  • ✅ Tests compile and cover both the rejection and success cases
  • ✅ The change to remove parents from the transfer list aligns properly with the new validation

The PR successfully fixes the subagent delegation issue as described.

@dgageot dgageot merged commit 92187d6 into docker:main Feb 8, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants