fix(completions): include model field in API request body#16
Merged
lostmygithubaccount merged 1 commit intomainfrom Apr 5, 2026
Merged
fix(completions): include model field in API request body#16lostmygithubaccount merged 1 commit intomainfrom
lostmygithubaccount merged 1 commit intomainfrom
Conversation
OpenAI's Chat Completions API requires the model field in the request body. The Completions wire format was the only one missing it. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
build_request()was ignoringconfig.model, producing requests without the requiredmodelfieldmodeltoCompletionsRequeststruct and populated it from config (withDEFAULT_MODELfallback), matching Messages and Responses formatscompletions.rsandmod.rsto verify model is present🤖 Generated with Claude Code