fix(client): handle \r\n SSE line endings, release GIL in Python#15
Merged
lostmygithubaccount merged 2 commits intomainfrom Apr 6, 2026
Merged
fix(client): handle \r\n SSE line endings, release GIL in Python#15lostmygithubaccount merged 2 commits intomainfrom
lostmygithubaccount merged 2 commits intomainfrom
Conversation
- Normalize \r\n to \n in SSE buffer before parsing (spec compliance) - Wrap blocking chat() with py.allow_threads() to release GIL during network I/O - Add tests for \r\n SSE event parsing Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
lostmygithubaccount
force-pushed
the
cody/sse-fixes
branch
from
1999eef to
ba4f3a0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
\r\nto\nin SSE buffer before parsing for spec compliancechat()network I/O in Python bindings viapy.allow_threads()\r\nSSE event parsing (single + multiple events)