-
Notifications
You must be signed in to change notification settings - Fork 7
Update dependencies. #49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
a002fb5
Update dependencies.
davidlehn 539b457
Update to `eslint@9`.
davidlehn fb33eae
Update dependencies.
davidlehn bfeb0d9
Revert to `chai@4` to keep Node.js 18 working.
davidlehn 6b8064b
Update node.js and action versions.
davidlehn 75ee1fd
Change workflow name.
davidlehn db8ff8e
Fix zizmor issues.
davidlehn File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,90 @@ | ||
| name: Main CI | ||
|
|
||
| on: [push] | ||
|
|
||
| permissions: {} | ||
|
|
||
| jobs: | ||
| lint: | ||
| runs-on: ubuntu-latest | ||
| timeout-minutes: 10 | ||
| strategy: | ||
| matrix: | ||
| node-version: [24.x] | ||
| steps: | ||
| - uses: actions/checkout@v6 | ||
| with: | ||
| persist-credentials: false | ||
| - name: Use Node.js ${{ matrix.node-version }} | ||
| uses: actions/setup-node@v6 | ||
| with: | ||
| node-version: ${{ matrix.node-version }} | ||
| - run: npm install | ||
| - name: Run eslint | ||
| run: npm run lint | ||
| test-node: | ||
| runs-on: ubuntu-latest | ||
| needs: [lint] | ||
| timeout-minutes: 10 | ||
| strategy: | ||
| matrix: | ||
| node-version: [18.x, 20.x, 22.x, 24.x] | ||
| steps: | ||
| - uses: actions/checkout@v6 | ||
| with: | ||
| persist-credentials: false | ||
| - name: Install with Node.js 24.x | ||
| uses: actions/setup-node@v6 | ||
| with: | ||
| node-version: 24.x | ||
| - run: npm install | ||
| - name: Use Node.js ${{ matrix.node-version }} | ||
| uses: actions/setup-node@v6 | ||
| with: | ||
| node-version: ${{ matrix.node-version }} | ||
| - name: Run ESM test with Node.js ${{ matrix.node-version }} | ||
| run: npm run test-node | ||
| - name: Run CJS test with Node.js ${{ matrix.node-version }} | ||
| run: npm run test-node-cjs | ||
| test-karma: | ||
| runs-on: ubuntu-latest | ||
| needs: [lint, test-node] | ||
| timeout-minutes: 10 | ||
| strategy: | ||
| matrix: | ||
| node-version: [24.x] | ||
| steps: | ||
| - uses: actions/checkout@v6 | ||
| with: | ||
| persist-credentials: false | ||
| - name: Use Node.js ${{ matrix.node-version }} | ||
| uses: actions/setup-node@v6 | ||
| with: | ||
| node-version: ${{ matrix.node-version }} | ||
| - run: npm install | ||
| - name: Run karma tests | ||
| run: npm run test-karma | ||
| coverage: | ||
| needs: [test-node, test-karma] | ||
| runs-on: ubuntu-latest | ||
| timeout-minutes: 10 | ||
| strategy: | ||
| matrix: | ||
| node-version: [24.x] | ||
| steps: | ||
| - uses: actions/checkout@v6 | ||
| with: | ||
| persist-credentials: false | ||
| - name: Use Node.js ${{ matrix.node-version }} | ||
| uses: actions/setup-node@v6 | ||
| with: | ||
| node-version: ${{ matrix.node-version }} | ||
| - run: npm install | ||
| - name: Generate coverage report | ||
| run: npm run coverage-ci | ||
| - name: Upload coverage to Codecov | ||
| uses: codecov/codecov-action@671740ac38dd9b0130fbe1cec585b89eea48d3de # v5.5.2 | ||
| with: | ||
| files: ./coverage/lcov.info | ||
| fail_ci_if_error: true | ||
| token: ${{ secrets.CODECOV_TOKEN }} | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,15 @@ | ||
| # @digitalbazaar/http-client ChangeLog | ||
|
|
||
| ## 4.2.1 - 2025-xx-xx | ||
| ## 4.3.0 - 2026-01-xx | ||
|
|
||
| ### Changed | ||
| - Update dependencies. | ||
| - `[email protected]`. | ||
| - `[email protected]`. | ||
| - Update dev dependencies. | ||
| - `eslint@9`. | ||
| - `eslint-config-digitalbazaar` to `@digitalbazaar/eslint-config@7`. | ||
| - Update test dependencies. | ||
|
|
||
| ### Fixed | ||
| - Update HTTPS test endpoint from dead service to to github.com. May hit rate | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| import config from '@digitalbazaar/eslint-config/universal-recommended'; | ||
|
|
||
| export default [ | ||
| ...config | ||
| ]; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -13,6 +13,6 @@ export function deferred(f) { | |
| onfulfilled, | ||
| onrejected | ||
| ); | ||
| }, | ||
| } | ||
| }; | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
18 is EOL so we don't need to test against it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Understood. I was leaving it at 18.x since the only support issue is the trivial testing need to use chai@4 vs 5+. I thought it would be good to be a bit more conservative in this case since this library might have wider use than many of our others in part due to the use in jsonld.js, which still supports 18.x. An undici@7 update would force the issue, so I thought it would be fine to wait until that change is tested to drop old version testing.