refactor and feat: Add parsing ability for NOMAD datafiles and breakout tests in test_pdf.py into respective files - #207
Merged
Conversation
cadenmyers13
commented
Aug 14, 2026
| # free-text instrument comment. | ||
| # Expected: The comment yields the neutron scattering type | ||
| # and the qmax, qdamp, and qbroad resolution parameters. | ||
| ( |
Contributor
Author
There was a problem hiding this comment.
Below is the only new thing added. Everything else is just reorganization.
cadenmyers13
commented
Aug 14, 2026
| @@ -0,0 +1,15 @@ | |||
| # 5000 | |||
Contributor
Author
There was a problem hiding this comment.
Also new testdata file
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #207 +/- ##
===========================================
+ Coverage 71.63% 82.40% +10.77%
===========================================
Files 25 27 +2
Lines 3437 4103 +666
===========================================
+ Hits 2462 3381 +919
+ Misses 975 722 -253
🚀 New features to boost your workflow:
|
Contributor
Author
|
@sbillinge ready for review. Shall we do a patch release? This is essentially a bug fix |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #206
All testing for the pdf module was in a singular function called
test_pdf.py. This breaks out the test into their respective files. I Also reorganized where some deprecated functions were located within the file to help with removal of these tests later.