Skip to content

Fix comments and a guide path left stale by the delayed-kill, Run end, and installer work - #1006

Open
dormouse-bot wants to merge 2 commits into
mainfrom
docs/stale-comments-oct
Open

dormouse-bot wants to merge 2 commits into
mainfrom
docs/stale-comments-oct

Conversation

@dormouse-bot

Copy link
Copy Markdown
Collaborator

These are comment and doc fixes only, with no behavior change. Each of these places was left describing code that recent merges changed:

  • TESTING_AND_MODIFICATION_GUIDE.md pointed at scripts/window-listeners.test.mjs. That file lives at standalone/scripts/window-listeners.test.mjs, which standalone's test script runs; there is no copy at the repo root.
  • requestKill in lib/src/components/Wall.tsx: the docstring still said "a Door reattaches first, an untouched shell closes at once". Since the reopen and delayed-kill work (Reopen closed Surfaces, Workspaces, and windows (⌘⇧T / u / dor reopen) #967, Labs: no-confirm delayed kill (pending kills with a restore window) #969), a close that closeKindOf says won't confirm runs at once, including a Door's close in place. A close that would confirm goes pending under Labs, and otherwise stages the overlay; only that last case reattaches a Door.
  • callerTypedTool in lib/src/components/wall/tool-takeover.ts said "both placements need it". A Tool ends with its run; host replacements hold it (scope tool-run, part 1) #979 removed the rerun-in-caller placement, so take-over is now its only consumer.
  • The header and extractFunction comments in scripts/installer-verify-test.mjs said each helper is defined once and listed five of them. The script extracts eight helpers, and env_file_value is defined twice in both installers. The script relies on that: it checks that the two copies are identical. The comments now give the actual placement.

node scripts/spec-lint.mjs and node scripts/installer-verify-test.mjs both pass locally.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Oct 4, 2026 •

Copy link
Copy Markdown

Deploying mouseterm with  Cloudflare Pages  Cloudflare Pages

Latest commit: 3e501f1
Status: ✅  Deploy successful!
Preview URL: https://cd7cc7d9.mouseterm.pages.dev
Branch Preview URL: https://docs-stale-comments-oct.mouseterm.pages.dev

View logs

@dormouse-bot dormouse-bot left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The colon after "checked identical" in the installer-verify-test.mjs header makes the placement list that follows read as the helpers being checked identical, when only env_file_value is. A sentence break fixes it; I'll push the same edit.

Comment thread scripts/installer-verify-test.mjs

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant