Fix comments and a guide path left stale by the delayed-kill, Run end, and installer work - #1006
Open
dormouse-bot wants to merge 2 commits into
Open
dormouse-bot wants to merge 2 commits into
dormouse-bot wants to merge 2 commits into
Conversation
…, and installer work
Deploying mouseterm with
|
| Latest commit: |
3e501f1
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://cd7cc7d9.mouseterm.pages.dev |
| Branch Preview URL: | https://docs-stale-comments-oct.mouseterm.pages.dev |
dormouse-bot
commented
Oct 4, 2026
dormouse-bot
left a comment
Collaborator
Author
There was a problem hiding this comment.
The colon after "checked identical" in the installer-verify-test.mjs header makes the placement list that follows read as the helpers being checked identical, when only env_file_value is. A sentence break fixes it; I'll push the same edit.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are comment and doc fixes only, with no behavior change. Each of these places was left describing code that recent merges changed:
TESTING_AND_MODIFICATION_GUIDE.mdpointed atscripts/window-listeners.test.mjs. That file lives atstandalone/scripts/window-listeners.test.mjs, whichstandalone'stestscript runs; there is no copy at the repo root.requestKillinlib/src/components/Wall.tsx: the docstring still said "a Door reattaches first, an untouched shell closes at once". Since the reopen and delayed-kill work (Reopen closed Surfaces, Workspaces, and windows (⌘⇧T / u / dor reopen) #967, Labs: no-confirm delayed kill (pending kills with a restore window) #969), a close thatcloseKindOfsays won't confirm runs at once, including a Door's close in place. A close that would confirm goes pending under Labs, and otherwise stages the overlay; only that last case reattaches a Door.callerTypedToolinlib/src/components/wall/tool-takeover.tssaid "both placements need it". A Tool ends with its run; host replacements hold it (scope tool-run, part 1) #979 removed the rerun-in-caller placement, so take-over is now its only consumer.extractFunctioncomments inscripts/installer-verify-test.mjssaid each helper is defined once and listed five of them. The script extracts eight helpers, andenv_file_valueis defined twice in both installers. The script relies on that: it checks that the two copies are identical. The comments now give the actual placement.node scripts/spec-lint.mjsandnode scripts/installer-verify-test.mjsboth pass locally.