Skip to content

chore: Add cloud engine test#480

Merged
adamspofford-dfinity merged 2 commits intomainfrom
spofford/cloud-engine-tests
Apr 1, 2026
Merged

chore: Add cloud engine test#480
adamspofford-dfinity merged 2 commits intomainfrom
spofford/cloud-engine-tests

Conversation

@adamspofford-dfinity
Copy link
Copy Markdown
Contributor

No description provided.

@adamspofford-dfinity adamspofford-dfinity requested a review from a team as a code owner March 31, 2026 19:47
Comment on lines +592 to +605
// Create the canister on the CloudEngine subnet
ctx.icp()
.current_dir(&project_dir)
.args([
"canister",
"create",
"my-canister",
"--subnet",
&cloud_engine_subnet_id,
"--environment",
"docker-engine-environment",
])
.assert()
.success();
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Users can create and deploy canisters on a cloud-engine subnet in local pocket-ic, just like any other subnet type?
I'd expect it to fail, since only engine admins can create canisters there.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The subnet admin can create canisters. The subnet admin is set by the image to be the anonymous principal.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A user should be able to create a canister on a cloud engine subnet in local pocket ic if they are doing it with the principal that is set as the admin of the engine.

let selected_subnet = self
.get_subnet()
.await
.map_err(|e| CreateOperationError::SubnetResolution { message: e })?;
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How are we not getting an error here when we are trying to create on a cloud engine?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why would you expect to get an error?

@adamspofford-dfinity adamspofford-dfinity merged commit 8c37d50 into main Apr 1, 2026
88 checks passed
@adamspofford-dfinity adamspofford-dfinity deleted the spofford/cloud-engine-tests branch April 1, 2026 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants