fix: RenameCanister not allowed on aborted canister#9465
Merged
alin-at-dfinity merged 1 commit intodfinity:masterfrom Mar 19, 2026
Merged
fix: RenameCanister not allowed on aborted canister#9465alin-at-dfinity merged 1 commit intodfinity:masterfrom
alin-at-dfinity merged 1 commit intodfinity:masterfrom
Conversation
basvandijk
added
the
security-review-passed
Contributor
alin-at-dfinity
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a benign bug where
RenameCanisterwould be allowed on an aborted canister. Since theRenameCanistermanagement endpoint is only allowed to be called by the migration canister and the migration canister enforces that the canister to be renamed must be stopped the situation cannot really happen in production, so this fix is mostly done for consistency across the board.