Skip to content

test: fix tests affected by enabling log_memory_store feature#9451

Merged
maksymar merged 25 commits intomasterfrom
maksym/fix-lms-related-tests
Mar 19, 2026
Merged

test: fix tests affected by enabling log_memory_store feature#9451
maksymar merged 25 commits intomasterfrom
maksym/fix-lms-related-tests

Conversation

@maksymar
Copy link
Contributor

@maksymar maksymar commented Mar 18, 2026

This PR fixes some tests that are affected by log_memory_store feature enabled.

log_memory_store feature is controlled via hardcoded constant that cannot be changed without recompiling a binary, therefore it's possible to miss broken tests for the feature that is not rolled out yet. This PR is fixing those tests.

Failures that were fixed:

//rs/execution_environment:execution_environment_test
failures:
❌    query_handler::tests::queries_to_frozen_canisters_are_rejected
✅    scheduler::tests::charging::charging_for_message_memory_works
❌    scheduler::tests::charging::only_charge_for_allocation_after_specified_duration
✅    scheduler::tests::finalization_clears_scheduled_canister_log_delta_sizes

//rs/ingress_manager:ingress_manager_test
failures:
❌    ingress_selector::tests::test_get_payload_canister_has_sufficient_cycles

//rs/migration_canister:migration_canister_test
failures:
❌    after_validation_insufficient_cycles
❌    validation_fails_insufficient_cycles

@github-actions github-actions bot added the test label Mar 18, 2026
@maksymar
Copy link
Contributor Author

Both tests with and without LMS feature enabled are passing now.
image

@maksymar maksymar marked this pull request as ready for review March 18, 2026 13:33
@maksymar maksymar requested review from a team as code owners March 18, 2026 13:33
@maksymar maksymar enabled auto-merge March 19, 2026 13:35
@maksymar maksymar added this pull request to the merge queue Mar 19, 2026
Merged via the queue into master with commit 29032fd Mar 19, 2026
38 checks passed
@maksymar maksymar deleted the maksym/fix-lms-related-tests branch March 19, 2026 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants