chore: add ic-xrc-types to workspace dependencies#9443
chore: add ic-xrc-types to workspace dependencies#9443jasonz-dfinity wants to merge 2 commits intomasterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR centralizes the ic-xrc-types dependency version by moving several crates from an inline pinned version to using the workspace-managed dependency, and adds ic-xrc-types to the workspace dependency list in the root Cargo.toml.
Changes:
- Switched multiple
rs/*crates fromic-xrc-types = "1.0.0"toic-xrc-types = { workspace = true }. - Added
ic-xrc-types = "1.0.0"under[workspace.dependencies]in the rootCargo.toml.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| rs/tests/testnets/Cargo.toml | Uses workspace-managed ic-xrc-types instead of a crate-local pinned version. |
| rs/nns/test_utils/Cargo.toml | Uses workspace-managed ic-xrc-types instead of a crate-local pinned version. |
| rs/nns/integration_tests/Cargo.toml | Uses workspace-managed ic-xrc-types instead of a crate-local pinned version. |
| rs/nns/cmc/Cargo.toml | Uses workspace-managed ic-xrc-types instead of a crate-local pinned version. |
| rs/nervous_system/integration_tests/Cargo.toml | Uses workspace-managed ic-xrc-types instead of a crate-local pinned version. |
| Cargo.toml | Adds ic-xrc-types to [workspace.dependencies] to support workspace-based dependency declarations. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
f6064d5 to
d43187a
Compare
There was a problem hiding this comment.
Pull request overview
This PR consolidates the ic-xrc-types crate versioning across the Rust workspace by moving it to the root [workspace.dependencies] and switching individual crates to inherit it, aligning Cargo’s dependency pin with the Bazel-side pin.
Changes:
- Added
ic-xrc-types = "1.2.0"to the rootCargo.tomlunder[workspace.dependencies]. - Updated 6 crate
Cargo.tomlfiles to useic-xrc-types = { workspace = true }instead of pinning versions locally.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| Cargo.toml | Adds ic-xrc-types as a workspace dependency at version 1.2.0. |
| rs/tests/testnets/Cargo.toml | Switches ic-xrc-types to inherit from workspace dependencies. |
| rs/rust_canisters/xrc_mock/Cargo.toml | Switches ic-xrc-types to inherit from workspace dependencies. |
| rs/nns/test_utils/Cargo.toml | Switches ic-xrc-types to inherit from workspace dependencies. |
| rs/nns/integration_tests/Cargo.toml | Switches ic-xrc-types to inherit from workspace dependencies. |
| rs/nns/cmc/Cargo.toml | Switches ic-xrc-types to inherit from workspace dependencies. |
| rs/nervous_system/integration_tests/Cargo.toml | Switches ic-xrc-types to inherit from workspace dependencies. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Why
Several crates pin ic-xrc-types individually at various versions (1.0.0, 1.1.0). The Bazel side already pins ^1.2.0 in rust.MODULE.bazel. This consolidates the Cargo side to match.
What