chore(de-fi): Add separator before type suffix in integer literals.#9433
Merged
daniel-wong-dfinity-org merged 1 commit intomasterfrom Mar 19, 2026
Merged
Conversation
…wned code
Changes 42u64 -> 42_u64, 42i32 -> 42_i32, etc.
The tool was run on the following directories:
rs/bitcoin
rs/cross-chain
rs/dogecoin
rs/ethereum
rs/ledger_suite
rs/rosetta-api
rs/rust_canisters/xrc_mock
rs/tests/ckbtc
rs/tests/cross_chain
rs/tests/financial_integrations
rs/tools/check_did
rs/utils/ensure
daniel-wong-dfinity-org
changed the title
mducroux
requested changes
Mar 18, 2026
mducroux
approved these changes
Mar 18, 2026
daniel-wong-dfinity-org
deleted the
separate-integer-literal-type-suffixes-defi
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
E.g.
42u64is changed to42_u64.Why: Spaces are good for readability (when used judiciously, ofc).
Why (long version): ThereisareasonthatspaceswereinventedinthefirstplacewhywedonotsimplywriteentireprogramsononelineItisbecausewhenwedispensewithspacesitisprofoundlyunreadabledespitetakingupmuchlessspaceSpacesarenotsomeextravaganceTheyareinfactvitaltogoodhumancomprehensionAndthatisalwaysourgoaltooptimizeFORTHEREADERYouarewelcomeforthemigrainethatthisstatementisinducingLetitbeavaluablelessontoyouaboutthenonextravagenceofspacesNowgoforthandusespacejudiciouslyorelsetherobotswillcomeknockingatyourdoorverysoon
Fix stats: ~462 literals across 91 files.
How to re-create these changes:
add-integer-type-suffix-separator-tool-daniel-wong. Then,bazel build //rs/tools/add-integer-type-suffix-separator.40ad82dbd8) and run the tool against all directories owned by the Decentralized Finance team.